Conversation
Signed-off-by: George Armstrong <georgea@nvidia.com>
📝 WalkthroughWalkthroughThe pull request adds "swe-rebench" to the EXCLUDED_DATASETS list in the GPU test evaluation script. This prevents the dataset from being processed during dataset preparation and evaluation phases. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdded
The change maintains consistency with the existing exclusion policy stated in the comment on line 27: "These don't support max_samples, require explicit parameters, or are very heavy to prepare" Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Test as test_aaa_prepare_and_eval_all_datasets
participant GDS as get_preparable_datasets()
participant Datasets as Dataset Directory
Dev->>Test: Run test suite
Test->>GDS: Get list of preparable datasets
GDS->>Datasets: Scan dataset directory
Datasets-->>GDS: Return all datasets with prepare.py
GDS->>GDS: Filter out EXCLUDED_DATASETS (includes swe-rebench)
GDS-->>Test: Return filtered dataset list
Test->>Test: Prepare and evaluate datasets
Note over Test,GDS: swe-rebench now excluded<br/>like swe-bench (requires<br/>explicit parameters)
|
Signed-off-by: George Armstrong <georgea@nvidia.com> Signed-off-by: dlord <dlord@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com> Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com> Signed-off-by: dgitman <dgitman@nvidia.com>
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.