FIX ioi ignore

[gwarmstrong]

Summary by CodeRabbit

• Tests
  • Updated dataset exclusion configuration in evaluation tests to consolidate excluded dataset entries.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The EXCLUDED_DATASETS set in the GPU test evaluation file was modified to replace two dataset entries ("ioi24", "ioi25") with a single, more general entry ("ioi").

Changes

Cohort / File(s)	Change Summary
Test dataset exclusion updates tests/gpu-tests/test_eval.py	Updated EXCLUDED_DATASETS set to replace "ioi24" and "ioi25" with "ioi" for dataset preparation/evaluation exclusion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Simple data structure update affecting only dataset exclusion configuration in a test file; minimal logic impact.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'FIX ioi ignore' directly relates to the changeset, which modifies the EXCLUDED_DATASETS set in the ioi dataset handling by replacing 'ioi24' and 'ioi25' with 'ioi'.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch georgea/fix-ioi-ignore

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eed4f7e and 5a35a24.

📒 Files selected for processing (1)

• tests/gpu-tests/test_eval.py (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: unit-tests
• GitHub Check: pre-commit

🔇 Additional comments (1)

tests/gpu-tests/test_eval.py (1)

36-36: Fix correctly consolidates to the actual dataset directory name.

The change from "ioi24" and "ioi25" to "ioi" is correct. Only the "ioi" dataset directory exists in nemo_skills/dataset/; the previous entries referenced non-existent directories. Since EXCLUDED_DATASETS uses exact string matching for dataset names, this fix ensures the correct dataset is properly excluded from the test suite.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}