Skip to content

fix: Fix activation checkpointing for mcore path #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Jul 21, 2025
Merged

fix: Fix activation checkpointing for mcore path #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nemo_rl/models/policy/megatron_policy_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,9 +496,9 @@ def __init__(
model_cfg.pipeline_dtype = dtype_map[self.cfg["megatron_cfg"]["pipeline_dtype"]]
model_cfg.parallel_output = True
if self.cfg["megatron_cfg"]["activation_checkpointing"]:
model_cfg.activations_checkpoint_granularity = "full"
model_cfg.activations_checkpoint_method = "uniform"
model_cfg.activations_checkpoint_num_layers = 1
model_cfg.recompute_granularity = "full"
model_cfg.recompute_method = "uniform"
model_cfg.recompute_num_layers = 1
if not model_cfg.gated_linear_unit:
assert model_cfg.activation_func is not None, (
"activation_func must be set if not using gated_linear_unit. This likely "
Expand Down
Loading