fix: Fix activation checkpointing for mcore path#703
Merged
Conversation
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
terrykong
approved these changes
Jul 21, 2025
guyueh1
approved these changes
Jul 21, 2025
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Jialei Chen <jialeic@google.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
rohitrango
pushed a commit
that referenced
this pull request
Jul 29, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Uses correct config for activation checkpointing. Thanks @guyueh1 for catching this!
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information