feat: optimize refit by reducing set of IPC handles sent to each device#634
Merged
feat: optimize refit by reducing set of IPC handles sent to each device#634
Conversation
f9e29be to
98f2b88
Compare
yuki-97
reviewed
Jul 10, 2025
guyueh1
reviewed
Jul 10, 2025
guyueh1
previously approved these changes
Jul 10, 2025
a3b950c to
97b4679
Compare
yuki-97
previously approved these changes
Jul 10, 2025
parthchadha
previously approved these changes
Jul 10, 2025
yfw
previously approved these changes
Jul 11, 2025
d8d87e0
d8d87e0 to
21cb80d
Compare
Contributor
Author
|
This change is compatible to async_llm. |
21cb80d to
d0f4e35
Compare
yfw
reviewed
Jul 14, 2025
yfw
previously approved these changes
Jul 14, 2025
guyueh1
previously approved these changes
Jul 14, 2025
Contributor
|
@ZhiyuLi-Nvidia |
Contributor
Author
Yeap. I have seen this implementation. I had some issues to correctly call it within
Let me know if you have any suggestions |
terrykong
approved these changes
Jul 15, 2025
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
Signed-off-by: Yuki Huang <yukih@nvidia.com> Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
ff05a1a to
22f18b9
Compare
ZhiyuLi-Nvidia
added a commit
that referenced
this pull request
Jul 21, 2025
…ce (#634) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
jialei777
pushed a commit
to jialei777/nemo-rl
that referenced
this pull request
Jul 23, 2025
…ce (NVIDIA-NeMo#634) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu
pushed a commit
that referenced
this pull request
Jul 28, 2025
…ce (#634) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com>
xxman-google
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Jul 30, 2025
…ce (NVIDIA-NeMo#634) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…ce (NVIDIA-NeMo#634) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com>
FannYYW
pushed a commit
to xxman-google/NeMo-RL
that referenced
this pull request
Aug 5, 2025
…ce (NVIDIA-NeMo#634) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 13, 2025
…ce (NVIDIA-NeMo#634) Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Optimization for refitting:
avoid waiting for update_weights_from_ipc_handles for better overlap:avoid unnecessary waiting time for better overlap ~8% gain in refitting speed in small scaleIssues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information