Skip to content

feat: add post_init to support get device_id in async vllm init#668

Merged
ZhiyuLi-Nvidia merged 1 commit intozhiyul/refit_optimizationfrom
yukih/fix-async-vllm-init
Jul 15, 2025
Merged

feat: add post_init to support get device_id in async vllm init#668
ZhiyuLi-Nvidia merged 1 commit intozhiyul/refit_optimizationfrom
yukih/fix-async-vllm-init

Conversation

@yuki-97
Copy link
Contributor

@yuki-97 yuki-97 commented Jul 15, 2025

We can't call report_device_id_async in VllmGenerationWorker's __init__ since it's not a async def function.
Add post_init for getting self.vllm_device_ids in async vllm.

Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 requested a review from ZhiyuLi-Nvidia July 15, 2025 06:26
@ZhiyuLi-Nvidia
Copy link
Contributor

Thank you @YUki-666 a lot!
LGTM!

@ZhiyuLi-Nvidia ZhiyuLi-Nvidia merged commit ff05a1a into zhiyul/refit_optimization Jul 15, 2025
7 checks passed
@ZhiyuLi-Nvidia ZhiyuLi-Nvidia deleted the yukih/fix-async-vllm-init branch July 15, 2025 06:56
ZhiyuLi-Nvidia pushed a commit that referenced this pull request Jul 15, 2025
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants