feat: Add Nemotron‑3 Nano 30B A3B GRPO nightly tests (FSDP2, +LoRA) #1866
Merged
feat: Add Nemotron‑3 Nano 30B A3B GRPO nightly tests (FSDP2, +LoRA) #1866
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR adds comprehensive GRPO (Generative Reward Process Optimization) support for the Nanov3 model, including documentation of DTensor LoRA configuration, two YAML recipe variants (with and without LoRA), corresponding test scripts with metric validation, and test suite registration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
terrykong
reviewed
Feb 4, 2026
Collaborator
terrykong
left a comment
There was a problem hiding this comment.
awesome!
can you:
- retroactively add lora to the news section in the front page readme? some users did not know we had this supported. maybe add an item that lora sft is supported in both backends, and dtensor grpo supported and to see our nano v3 recipe (and mention mcore coming soon)
- do you think we'd see more interesting reward curves if we did base for model_name but the reasoning model for the tokenizer_name?
d726426 to
9cc9c08
Compare
Contributor
Author
Done for both 1 and 2. Attatched new running curve to PR doc. |
58c7f91 to
8c5dba6
Compare
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
…just linear matching settings Signed-off-by: ruit <ruit@nvidia.com>
…tput projection modules for clarity Signed-off-by: ruit <ruit@nvidia.com>
aea477e to
05541c5
Compare
terrykong
approved these changes
Feb 6, 2026
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 12, 2026
…VIDIA-NeMo#1866) Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 21, 2026
…VIDIA-NeMo#1866) Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
…1866) Signed-off-by: ruit <ruit@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
…1866) Signed-off-by: ruit <ruit@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 9, 2026
…1866) Signed-off-by: ruit <ruit@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
*out_proj*modules in lora layers.nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16as tokenizer andnvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-Base-BF16as model.nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16, it's too long to write in yaml directly, then an additional file needs to be added to store the chat template.Convergence Test
Different configs have different accuracy, choose dim=128, alpha=512 as the recipe config.

SFT
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit
Documentation
New Features
Tests