chore: add nanov3 lora sft recipe to doc#1860
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughAdds a reference link to a full configuration example for SFT LoRA setup in the documentation guide's policy section, immediately following example usage without introducing any functional changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/guides/sft.md`:
- Line 237: There is a mismatch between the link text and the actual filename in
the markdown link: the display shows "sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml"
but the linked path points to "sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml"; fix by
making the display text match the real file name (or update the path if the
intended file was 2n4g), i.e., update the markdown link text or the target so
both use the same exact filename "sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml" (or
"sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml" if that is the correct file) in the
docs/guides/sft.md link line.
- Line 237: The link text and target mismatch: the text references
sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml while the URL points to
sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml; pick the intended recipe (either 2n4g or
2n8g) and make the link text and the URL consistent in the sentence referencing
the example (update either the displayed text or the URL so both use the same
filename, e.g., change the text to sft-nanov3-30BA3B-2n8g-fsdp2-lora.yaml if
that is the desired file or update the URL to
sft-nanov3-30BA3B-2n4g-fsdp2-lora.yaml to match the current text).
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
Signed-off-by: ruit <ruit@nvidia.com>
95b4838 to
81e3dc7
Compare
yuki-97
approved these changes
Feb 2, 2026
terrykong
approved these changes
Feb 2, 2026
4 tasks
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 12, 2026
Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
yuanhangsu1986
pushed a commit
to yuanhangsu1986/RL-Nemontron-Edge-Omni
that referenced
this pull request
Feb 21, 2026
Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: yuanhangs <yuanhangs@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: ruit <ruit@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 8, 2026
Signed-off-by: ruit <ruit@nvidia.com>
seonjinn
pushed a commit
that referenced
this pull request
Mar 9, 2026
Signed-off-by: ruit <ruit@nvidia.com>
Aniketsy
pushed a commit
to Aniketsy/RL
that referenced
this pull request
Mar 29, 2026
Signed-off-by: ruit <ruit@nvidia.com> Signed-off-by: Aniket Singh Yadav <singhyadavaniket43@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.