-
Notifications
You must be signed in to change notification settings - Fork 176
fix: lower steps in smolvlm nightly test #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
695fe82 to
dedd010
Compare
📝 WalkthroughWalkthroughNightly test suite updated to reference a new VLM test script version. The new script reduces step counts, updates metric checkpoints to step 130, and changes the reward validation from a single-point threshold to a trailing-window mean check. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Nightly as Nightly Suite
participant Script as VLM v2 Test Script
participant Trainer as Training Job
participant Metrics as Metrics Reader
Nightly->>Script: Invoke test script
Script->>Trainer: Launch training (MAX_STEPS=130)
Trainer-->>Script: Emit logs/metrics
Script->>Metrics: Parse metrics at step 130
rect rgba(200,230,255,0.3)
note right of Metrics: Changed check
Metrics-->>Script: Compute mean(train/reward[130][-6:-1])
Script-->>Nightly: Assert mean > 0.6 and other step-130 checks
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0111fbe to
2a16654
Compare
fix Signed-off-by: Terry Kong <[email protected]> rename Signed-off-by: Terry Kong <[email protected]> fix Signed-off-by: Terry Kong <[email protected]> fix Signed-off-by: Terry Kong <[email protected]>
2a16654 to
d7d41a1
Compare
Signed-off-by: Terry Kong <[email protected]>
Signed-off-by: Terry Kong <[email protected]>
The smolvlm test was never able to get 200 steps in 3 hours. This lowers the step count and makes the final accuracy check an average
https://wandb.ai/nvidia/nemo-rl?nw=x2dvezg4z1l
After #1115 merged the smolvlm test was disabled, I ran the config to check if the metrics would have caught that issue, and it does:
Summary by CodeRabbit