Skip to content

fix: lower steps in smolvlm nightly test #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 2 commits into from
Oct 2, 2025
Merged

fix: lower steps in smolvlm nightly test #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7d41a1
https://wandb.ai/nvidia/nemo-rl?nw=x2dvezg4z1l
terrykong Sep 30, 2025
6d2a93e
disabled
terrykong Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...t-clevr-1n2g-dtensor2tp1.v1.yaml.disabled → ...t-clevr-1n2g-dtensor2tp1.v2.yaml.disabled
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/test_suites/nightly.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ tests/test_suites/vlm/vlm_grpo-qwen2.5-vl-3b-instruct-clevr-1n2g-dtensor2tp1.v1.
tests/test_suites/vlm/vlm_grpo-qwen2.5-vl-3b-instruct-clevr-1n2g-megatrontp2.v1.sh

# Removing this until this issue is resolved: https://github.com/huggingface/transformers/issues/41190
# tests/test_suites/vlm/vlm_grpo-smolvlm2-2.2b-instruct-clevr-1n2g-dtensor2tp1.v1.sh
# tests/test_suites/vlm/vlm_grpo-smolvlm2-2.2b-instruct-clevr-1n2g-dtensor2tp1.v2.sh

# Deepscaler (short tests)
tests/test_suites/llm/grpo-deepscaler-1.5b-16K.sh
Expand Down
8 changes: 4 additions & 4 deletions ...uct-clevr-1n2g-dtensor2tp1.v1.sh.disabled → ...uct-clevr-1n2g-dtensor2tp1.v2.sh.disabled
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ source $SCRIPT_DIR/common.env

# ===== BEGIN CONFIG =====
NUM_NODES=1
STEPS_PER_RUN=200
MAX_STEPS=200
STEPS_PER_RUN=130
MAX_STEPS=130
NUM_RUNS=$(( (MAX_STEPS + STEPS_PER_RUN - 1) / STEPS_PER_RUN )) # Round up
NUM_MINUTES=180
# ===== END CONFIG =====
Expand Down Expand Up @@ -34,7 +34,7 @@ uv run tests/json_dump_tb_logs.py $LOG_DIR --output_path $JSON_METRICS
# Only run metrics if the target step is reached
if [[ $(jq 'to_entries | .[] | select(.key == "train/loss") | .value | keys | map(tonumber) | max' $JSON_METRICS) -ge $MAX_STEPS ]]; then
uv run tests/check_metrics.py $JSON_METRICS \
'data["train/loss"]["200"] < 0.1' \
'data["train/reward"]["200"] > 0.7' # less performant than qwen
'data["train/loss"]["130"] < 0.1' \
'mean(data["train/reward"], -6, -1) > 0.6' # less performant than qwen
fi

Loading