-
Notifications
You must be signed in to change notification settings - Fork 173
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Refactor the SFT and GRPO entry script to adopt the new dataset processor interface introduced in RawDataset and the PROCESSOR_REGISTRY, removing ad‑hoc preprocessing and aligning with the GRPO data path.
Motivation
We recently introduced a unified processor interface and registration mechanism for datasets in PR !1506. The SFT path still wires processors and preprocessing via partials in run_sft.py, which diverges from the new interface and duplicates logic. Unifying both paths reduces maintenance, enables consistent configuration, and simplifies documentation.
Scope
- Replace ad‑hoc processor wiring in run_sft.py with the standard processor interface (TaskDataSpec + PROCESSOR_REGISTRY).
- Ensure datasets used by SFT can declare/select their processor consistently via config (e.g., data.processor).
- Make STF dataset inherit RawDataset class. Unified dataset interface.
- Keep parity with existing SFT features (optional BOS/EOS, add_generation_prompt, optional image preprocessing for CLEVR, etc.) by moving them into the processor layer where appropriate.
- Move customized OmegaConf op into a common place. Refer to this comment.
- Unify dataset initialize with
super.init. Refer to this comment.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request