-
Notifications
You must be signed in to change notification settings - Fork 173
refactor: refactor env and data processor & add nemotron super 49b recipes #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuki-97
wants to merge
17
commits into
main
Choose a base branch
from
yukih/pr-1472
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ce8f6f1
MergeGRPO to main
nv-mmanohara a294ddc
MergeGRPO to main
nv-mmanohara 8924c20
SFT update
nv-mmanohara 1a39d70
Resolving comments
nv-mmanohara 6be7124
lint
yuki-97 5ccfc95
refactor yaml
yuki-97 dc29f54
update custom parallel plan doc
yuki-97 8d09a2e
revert logger.py
yuki-97 0c681cc
unify run_grpo with multiple env
RayenTian bead01d
remove useless code
yuki-97 8b3d661
Enhance dataset handling by introducing RawDataset class and updating…
RayenTian 152d289
Add Code Jaccard Environment documentation and update dataset process…
RayenTian 8a0d128
Refactor dataset classes to inherit from RawDataset
RayenTian f38b6d6
Update environment configuration in YAML files and adjust dataset set…
RayenTian a24ba76
Remove unused base model parallel plan from custom parallel configura…
RayenTian 5f8300d
fix doc
RayenTian 5f17693
fix model path
yuki-97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
.../configs/recipes/llm/grpo-helpsteer3-llama-3.3-nemotron-super-49b-v1.5-4n8g-fsdp2tp8.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| defaults: ../../grpo_math_1B.yaml | ||
| grpo: | ||
| num_prompts_per_step: 64 | ||
| max_num_steps: 10 | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-helpsteer3-llama-3.3-nemotron-super-49b-v1.5 | ||
| metric_name: val:reward | ||
| policy: | ||
| # This is the model name is unusable because the model did bot update on huggingface yet. | ||
| # ISSUE: https://github.com/NVIDIA-NeMo/RL/issues/1571 | ||
| model_name: nvidia/Llama-3_3-Nemotron-Super-49B-v1_5 | ||
| max_total_sequence_length: 32768 | ||
| train_global_batch_size: 64 | ||
| train_micro_batch_size: 1 | ||
| logprob_batch_size: 1 | ||
| dtensor_cfg: | ||
| activation_checkpointing: true | ||
| context_parallel_size: 4 | ||
| cpu_offload: true | ||
| tensor_parallel_size: 8 | ||
| custom_parallel_plan: examples.custom_parallel.llama_nemotron_super_49b_custom_plan.custom_parallel_plan | ||
| dynamic_batching: | ||
| enabled: true | ||
| sequence_packing: | ||
| enabled: false | ||
| optimizer: | ||
| kwargs: | ||
| lr: 3.0e-07 | ||
| scheduler: | ||
| - name: torch.optim.lr_scheduler.LinearLR | ||
| kwargs: | ||
| start_factor: 0.1 | ||
| end_factor: 1.0 | ||
| total_iters: 13 | ||
| - name: torch.optim.lr_scheduler.ConstantLR | ||
| kwargs: | ||
| factor: 1.0 | ||
| total_iters: 10000000000 | ||
| - milestones: | ||
| - 13 | ||
| generation: | ||
| vllm_cfg: | ||
| tensor_parallel_size: 4 | ||
| data: | ||
| # Training with HelpSteer3 will lead to high logprob error. | ||
| # ISSUE: https://github.com/NVIDIA-NeMo/RL/issues/1570 | ||
| prompt_file: null | ||
| dataset_name: HelpSteer3 | ||
| split: preference | ||
| env_name: "code_jaccard" | ||
| processor: helpsteer3_data_processor | ||
| env: | ||
| code_jaccard: | ||
| num_workers: 8 | ||
| logger: | ||
| wandb_enabled: true | ||
| wandb: | ||
| project: grpo-helpsteer3-llama-3.3-nemotron-super-49b-v1.5 | ||
| name: grpo-helpsteer3-llama-3.3-nemotron-super-49b-v1.5-tp${policy.dtensor_cfg.tensor_parallel_size} | ||
| tensorboard: | ||
| log_dir: tb_logs-grpo-helpsteer3-llama-3.3-nemotron-super-49b-v1.5 | ||
| mlflow: | ||
| experiment_name: grpo-helpsteer3 | ||
| run_name: grpo-helpsteer3-llama-3.3-nemotron-super-49b-v1.5 | ||
| cluster: | ||
| gpus_per_node: 8 | ||
| num_nodes: 16 |
47 changes: 0 additions & 47 deletions
47
...es/configs/recipes/llm/grpo-math-llama-nemotron-super-49b-v.5-4n8g-fsdp2tp8.yaml.disabled
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.