-
Notifications
You must be signed in to change notification settings - Fork 3.2k
added hyper param search feature in jasper_infer.py #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Hariankar H <[email protected]>
examples/asr/jasper_infer.py
Outdated
| checkpoint_dir=checkpoint_dir, | ||
| ) | ||
|
|
||
| greedy_hypotheses = post_process_predictions( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is no need to add greedy_hypotheses here for each round evaluation of alpha & beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Slyne thanks for pointing it out. Removed it.
Signed-off-by: Hariankar H <[email protected]>
|
the CI fails because of PEP8 issue: Could you please run "pycodestyle" before the check-in? (see below) |
Signed-off-by: Hariankar H <[email protected]>
|
fixed the pep8 issues |
|
Do you plan on using the infer mode? If not, I plan on removing infer mode and renaming the file to jasper_eval.py since the intended use case for that file is mainly eval. |
The PR add configuration to the CLI and provides default configuration file. Signed-off-by: Martin Hickey <[email protected]>
Signed-off-by: Shehzeen Hussain <[email protected]>
Added grid search-based alpha-beta hyper param tuning code in
jasper_infer.py. Incorporated suggestions from pull request #55.Added following changes:
beam_widthparameter to override default 128alpha_step,beta_stepparameters to define steps for grid searchalpha_from/beta_fromto justalpha/betaso that it is possible to do inference with a single set of alpha/beta values (without tuning over a grid)Signed-off-by: Hariankar H [email protected]