Skip to content

Conversation

@harisankarh
Copy link
Contributor

This will help in selecting the appropriate alpha and beta parameters for a given validation set (similar to tune.py in Deepspeech2).

Signed-off-by: Hariankar H [email protected]

@okuchaiev okuchaiev requested a review from vsl9 October 18, 2019 23:08
@okuchaiev
Copy link
Collaborator

I think this should just be merged with "examples/asr/jasper.py" @vsl9 and @blisc what do you think?

@okuchaiev okuchaiev requested a review from blisc October 18, 2019 23:10
@vsl9
Copy link
Collaborator

vsl9 commented Oct 19, 2019

Harisankar, thanks a lot for the PR!
I agree with Oleksii that instead of creating a new script it is worth to modify original jasper_infer.py.
Some nice things to add:

  • beam_width parameter to override default 128
  • alpha_step, beta_step parameters to define steps for grid search
  • rename alpha_from/beta_from to just alpha/beta so that it is possible to do inference with a single set of alpha/beta values (without tuning over a grid)
    There is a similar script in our OpenSeq2Seq project: https://github.com/NVIDIA/OpenSeq2Seq/blob/master/scripts/decode.py
    It would be great to implement a similar command line API with beam_width, alpha, alpha_max, alpha_step, beta, beta_max, beta_step in jasper_infer.py to support a single inference or tuning.

Copy link
Collaborator

@vsl9 vsl9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment.

@harisankarh
Copy link
Contributor Author

Thanks for the feedback. I'll look into it.

@harisankarh
Copy link
Contributor Author

harisankarh commented Oct 24, 2019

@vsl9 I've made the changes you suggested. Created fresh pull request #67.

Closing this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants