Skip to content

added b300/b200 support for perf plugins. B200/B300 must have expenda… - #3776

Open
rsalagame-nvidia wants to merge 1 commit into
mainfrom
rsalagame-main-expandable-segments-true-b300-b200
Open

added b300/b200 support for perf plugins. B200/B300 must have expenda…#3776
rsalagame-nvidia wants to merge 1 commit into
mainfrom
rsalagame-main-expandable-segments-true-b300-b200

Conversation

@rsalagame-nvidia

Copy link
Copy Markdown
Contributor

Adding B300/B200 support for expendable segements. Resolved CUDA OOM issue as noticed from QA test cycle nvbug: https://nvbugspro.nvidia.com/bug/6160449

…ble segments as well.

Signed-off-by: Rahul Salagame <rsalagame@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented May 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@claude

claude Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Light Review: The change is correct. One note: the deepseek_v3 block (line 299) is missing b300/gb300 in its gpu list despite having configs for those GPUs -- worth a follow-up. Suggested test cases: llama31_405b_pretrain_config_b300 (bf16, fp8_cs, fp8_mx, nvfp4), llama31_405b_pretrain_config_b200 (bf16, fp8_cs, fp8_mx, nvfp4). bf16 variants are negative controls (should NOT get expandable_segments set).

@claude

claude Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Light Review: The change is correct. Potential issue (not blocking): deepseek_v3 block at line 299 does not include b300 or gb300 in its gpu list -- worth a follow-up check. Suggested test cases: llama31_405b_pretrain_config_b300 (bf16, fp8_cs, fp8_mx, nvfp4), llama31_405b_pretrain_config_b200 (bf16, fp8_cs, fp8_mx, nvfp4). bf16 is a negative control (should NOT get expandable_segments set).

@yaoyu-33 yaoyu-33 added area:perf Performance optimizations and benchmarking bug Something isn't working needs-review PR is ready for code review and waiting on a reviewer labels May 12, 2026
@yaoyu-33

Copy link
Copy Markdown
Contributor

@rsalagame-nvidia can you check ai comment + resolve conflicts.

@yaoyu-33 yaoyu-33 added waiting-on-customer Waiting on the original author to respond and removed needs-review PR is ready for code review and waiting on a reviewer labels May 14, 2026
@malay-nagda

Copy link
Copy Markdown
Contributor

@rsalagame-nvidia this might not be needed after- #3781.
this flag is enabled for all cases except when FSDP/nccl_ub is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:perf Performance optimizations and benchmarking bug Something isn't working waiting-on-customer Waiting on the original author to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants