chore(beep boop 🤖): Bump uv.lock (main) (2026-03-17)#2829
chore(beep boop 🤖): Bump uv.lock (main) (2026-03-17)#2829svcnvidia-nemo-ci wants to merge 5 commits intomainfrom
uv.lock (main) (2026-03-17)#2829Conversation
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
/ok to test a90946a |
📝 WalkthroughWalkthroughThis pull request updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule pointer at 3rdparty/Megatron-LM references a
non-existent commit (9374a4d328641a2fbbad4fd41cf038b539dcf1e6); verify the
intended upstream commit or tag in the Megatron-LM repo, update the submodule
reference to a valid commit/branch/tag, commit the updated submodule pointer
(stage the 3rdparty/Megatron-LM change) and push the update so the repository no
longer contains the broken commit hash.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 67fceb37-0373-47cf-86b2-b18bd47ba247
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
3rdparty/Megatron-LM
| @@ -1 +1 @@ | |||
| Subproject commit 905c0e38655a61e603529b972ca9fdffd7daa667 | |||
| Subproject commit 9374a4d328641a2fbbad4fd41cf038b539dcf1e6 | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
OLD_COMMIT="905c0e38655a61e603529b972ca9fdffd7daa667"
NEW_COMMIT="9374a4d328641a2fbbad4fd41cf038b539dcf1e6"
echo "== Superproject changed files =="
git show --name-only --pretty="" HEAD | sed '/^$/d'
echo
echo "== Verify submodule commit exists =="
git -C 3rdparty/Megatron-LM rev-parse --verify "${NEW_COMMIT}^{commit}"
echo
echo "== Upstream commits between old and new =="
git -C 3rdparty/Megatron-LM log --oneline --no-merges "${OLD_COMMIT}..${NEW_COMMIT}" | head -200
echo
echo "== Files changed in submodule range =="
git -C 3rdparty/Megatron-LM diff --name-status "${OLD_COMMIT}" "${NEW_COMMIT}" | head -300Repository: NVIDIA-NeMo/Megatron-Bridge
Length of output: 50574
Cannot merge: submodule commit does not exist in repository.
The new submodule commit 9374a4d328641a2fbbad4fd41cf038b539dcf1e6 does not exist in the Megatron-LM upstream repository. This is a broken pointer that will fail during clones or builds. Verify the correct commit hash and re-push.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@3rdparty/Megatron-LM` at line 1, The submodule pointer at
3rdparty/Megatron-LM references a non-existent commit
(9374a4d328641a2fbbad4fd41cf038b539dcf1e6); verify the intended upstream commit
or tag in the Megatron-LM repo, update the submodule reference to a valid
commit/branch/tag, commit the updated submodule pointer (stage the
3rdparty/Megatron-LM change) and push the update so the repository no longer
contains the broken commit hash.
|
/ok to test 35551ca |
Signed-off-by: oliver könig <okoenig@nvidia.com>
|
/ok to test 2749c2e |
…in compat `get_mup_config_overrides` exists in mcore dev but not yet in the main branch tracked by the submodule. Guard the import with try/except so unit tests pass against the submodule mcore (fixes bump PR #2829 CI). Also adds the `mcore-compat` skill documenting the pattern for future main/dev divergence cases. TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main. Signed-off-by: Yu Yao <yaoyu.094@gmail.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
…in compat `get_mup_config_overrides` exists in mcore dev but not yet in the main branch tracked by the submodule. Guard the import with try/except so unit tests pass against the submodule mcore (fixes bump PR #2829 CI). Also adds the `mcore-compat` skill documenting the pattern for future main/dev divergence cases. TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main. Signed-off-by: Yu Yao <yaoyu.094@gmail.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
…in compat `get_mup_config_overrides` exists in mcore dev but not yet in the main branch tracked by the submodule. Guard the import with try/except so unit tests pass against the submodule mcore (fixes bump PR #2829 CI). Also adds the `mcore-compat` skill documenting the pattern for future main/dev divergence cases. TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main. Signed-off-by: Yu Yao <yaoyu.094@gmail.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
…in compat `get_mup_config_overrides` exists in mcore dev but not yet in the main branch tracked by the submodule. Guard the import with try/except so unit tests pass against the submodule mcore (fixes bump PR #2829 CI). Also adds the `mcore-compat` skill documenting the pattern for future main/dev divergence cases. TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main. Signed-off-by: Yu Yao <yaoyu.094@gmail.com> Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
|
/ok to test |
@yaoyu-33, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
🚀 PR to bump
uv.lockinmain.🤖 This PR will be merged automatically once CI passes.
Summary by CodeRabbit