Skip to content

chore(beep boop 🤖): Bump uv.lock (main) (2026-03-17)#2829

Closed
svcnvidia-nemo-ci wants to merge 5 commits intomainfrom
bump-ci-container-2026-03-17-main-dev
Closed

chore(beep boop 🤖): Bump uv.lock (main) (2026-03-17)#2829
svcnvidia-nemo-ci wants to merge 5 commits intomainfrom
bump-ci-container-2026-03-17-main-dev

Conversation

@svcnvidia-nemo-ci
Copy link
Contributor

@svcnvidia-nemo-ci svcnvidia-nemo-ci commented Mar 17, 2026

🚀 PR to bump uv.lock in main.

🤖 This PR will be merged automatically once CI passes.

Summary by CodeRabbit

  • Chores
    • Updated a third-party dependency to the latest version.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@svcnvidia-nemo-ci
Copy link
Contributor Author

/ok to test a90946a

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 17, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

📝 Walkthrough

Walkthrough

This pull request updates the 3rdparty/Megatron-LM submodule pointer from commit 905c0e3 to 9374a4d. The change involves only a single-line modification to a submodule reference with no direct code alterations to the repository itself.

Changes

Cohort / File(s) Summary
Submodule Update
3rdparty/Megatron-LM
Updated submodule pointer to a new commit reference; no behavioral changes to the repository code.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • yaoyu-33
  • maanug-nv
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title uses non-descriptive casual language ('beep boop 🤖') and emoji, obscuring the actual change. While it mentions 'Bump uv.lock', the primary focus is on the submodule pointer update for Megatron-LM, which is not reflected in the title. Revise the title to be more descriptive and professional, such as 'chore: Update 3rdparty/Megatron-LM submodule pointer and bump uv.lock' to clearly communicate the main changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed This PR contains only minor changes (dependency lock file bumps and submodule pointer updates) with no code or behavioral changes, as explicitly documented in the summary. The estimated review effort is low, and the PR is categorized as a chore/maintenance update. Per the custom check instructions, test results are not required for minor changes. Therefore, no regression testing or performance benchmarking is needed for this type of maintenance update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ci-container-2026-03-17-main-dev
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@3rdparty/Megatron-LM`:
- Line 1: The submodule pointer at 3rdparty/Megatron-LM references a
non-existent commit (9374a4d328641a2fbbad4fd41cf038b539dcf1e6); verify the
intended upstream commit or tag in the Megatron-LM repo, update the submodule
reference to a valid commit/branch/tag, commit the updated submodule pointer
(stage the 3rdparty/Megatron-LM change) and push the update so the repository no
longer contains the broken commit hash.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 67fceb37-0373-47cf-86b2-b18bd47ba247

📥 Commits

Reviewing files that changed from the base of the PR and between 57d10ad and a90946a.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • 3rdparty/Megatron-LM

@@ -1 +1 @@
Subproject commit 905c0e38655a61e603529b972ca9fdffd7daa667
Subproject commit 9374a4d328641a2fbbad4fd41cf038b539dcf1e6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

OLD_COMMIT="905c0e38655a61e603529b972ca9fdffd7daa667"
NEW_COMMIT="9374a4d328641a2fbbad4fd41cf038b539dcf1e6"

echo "== Superproject changed files =="
git show --name-only --pretty="" HEAD | sed '/^$/d'

echo
echo "== Verify submodule commit exists =="
git -C 3rdparty/Megatron-LM rev-parse --verify "${NEW_COMMIT}^{commit}"

echo
echo "== Upstream commits between old and new =="
git -C 3rdparty/Megatron-LM log --oneline --no-merges "${OLD_COMMIT}..${NEW_COMMIT}" | head -200

echo
echo "== Files changed in submodule range =="
git -C 3rdparty/Megatron-LM diff --name-status "${OLD_COMMIT}" "${NEW_COMMIT}" | head -300

Repository: NVIDIA-NeMo/Megatron-Bridge

Length of output: 50574


Cannot merge: submodule commit does not exist in repository.

The new submodule commit 9374a4d328641a2fbbad4fd41cf038b539dcf1e6 does not exist in the Megatron-LM upstream repository. This is a broken pointer that will fail during clones or builds. Verify the correct commit hash and re-push.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/Megatron-LM` at line 1, The submodule pointer at
3rdparty/Megatron-LM references a non-existent commit
(9374a4d328641a2fbbad4fd41cf038b539dcf1e6); verify the intended upstream commit
or tag in the Megatron-LM repo, update the submodule reference to a valid
commit/branch/tag, commit the updated submodule pointer (stage the
3rdparty/Megatron-LM change) and push the update so the repository no longer
contains the broken commit hash.

@yaoyu-33
Copy link
Contributor

/ok to test 35551ca

Signed-off-by: oliver könig <okoenig@nvidia.com>
@yaoyu-33
Copy link
Contributor

/ok to test 2749c2e

yaoyu-33 added a commit that referenced this pull request Mar 17, 2026
…in compat

`get_mup_config_overrides` exists in mcore dev but not yet in the main
branch tracked by the submodule. Guard the import with try/except so
unit tests pass against the submodule mcore (fixes bump PR #2829 CI).

Also adds the `mcore-compat` skill documenting the pattern for future
main/dev divergence cases.

TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main.

Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
yaoyu-33 added a commit that referenced this pull request Mar 17, 2026
…in compat

`get_mup_config_overrides` exists in mcore dev but not yet in the main
branch tracked by the submodule. Guard the import with try/except so
unit tests pass against the submodule mcore (fixes bump PR #2829 CI).

Also adds the `mcore-compat` skill documenting the pattern for future
main/dev divergence cases.

TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main.

Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
yaoyu-33 added a commit that referenced this pull request Mar 17, 2026
…in compat

`get_mup_config_overrides` exists in mcore dev but not yet in the main
branch tracked by the submodule. Guard the import with try/except so
unit tests pass against the submodule mcore (fixes bump PR #2829 CI).

Also adds the `mcore-compat` skill documenting the pattern for future
main/dev divergence cases.

TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main.

Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
…in compat

`get_mup_config_overrides` exists in mcore dev but not yet in the main
branch tracked by the submodule. Guard the import with try/except so
unit tests pass against the submodule mcore (fixes bump PR #2829 CI).

Also adds the `mcore-compat` skill documenting the pattern for future
main/dev divergence cases.

TODO: Remove the guard once `get_mup_config_overrides` lands in mcore main.

Signed-off-by: Yu Yao <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
@yaoyu-33
Copy link
Contributor

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 17, 2026

/ok to test

@yaoyu-33, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@yaoyu-33 yaoyu-33 added the needs-more-tests Requires additional L0 and L1 test coverage before merge label Mar 17, 2026
@yaoyu-33 yaoyu-33 closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-more-tests Requires additional L0 and L1 test coverage before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants