Skip to content

chore: Remove pytest_sessionfinish#2840

Merged
ko3n1g merged 1 commit intomainfrom
ko3n1g/ci/remove-pytest_sessionfinish
Mar 17, 2026
Merged

chore: Remove pytest_sessionfinish#2840
ko3n1g merged 1 commit intomainfrom
ko3n1g/ci/remove-pytest_sessionfinish

Conversation

@ko3n1g
Copy link
Contributor

@ko3n1g ko3n1g commented Mar 17, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Tests
    • Removed test session hook that was forcing immediate process termination. Tests now complete with standard cleanup procedures and normal exit handling, enabling more reliable test shutdown behavior.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f98988d9-6097-47ff-b641-07700bfc7453

📥 Commits

Reviewing files that changed from the base of the PR and between 9e455b3 and 1528f34.

📒 Files selected for processing (1)
  • tests/unit_tests/conftest.py
💤 Files with no reviewable changes (1)
  • tests/unit_tests/conftest.py

📝 Walkthrough

Walkthrough

The pytest_sessionfinish hook has been removed from tests/unit_tests/conftest.py. This hook previously forced process termination via os._exit() to work around PyTorch/CUDA cleanup issues. With its removal, test session cleanup now relies on standard pytest behavior.

Changes

Cohort / File(s) Summary
Test Configuration
tests/unit_tests/conftest.py
Removed pytest_sessionfinish hook that forced process exit via os._exit(). Test fixtures and setup remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the pytest_sessionfinish function from the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed This PR removes a pytest_sessionfinish hook from test infrastructure, a minor housekeeping change unrelated to core functionality that does not affect numerics, convergence, or performance.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ko3n1g/ci/remove-pytest_sessionfinish
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ko3n1g ko3n1g merged commit 6d8a1c5 into main Mar 17, 2026
18 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/remove-pytest_sessionfinish branch March 17, 2026 17:47
yaoyu-33 pushed a commit that referenced this pull request Mar 17, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
copy-pr-bot bot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants