Skip to content

build: Add setup.py to first layers#2420

Merged
ko3n1g merged 1 commit intomainfrom
ko3n1g/build/compile-helper-2
Feb 18, 2026
Merged

build: Add setup.py to first layers#2420
ko3n1g merged 1 commit intomainfrom
ko3n1g/build/compile-helper-2

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 18, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Updated Docker build configuration to include additional dependency files for the Megatron-LM module.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The Dockerfile.ci COPY instruction was modified to include 3rdparty/Megatron-LM/setup.py alongside the existing pyproject.toml file from the Megatron-LM submodule.

Changes

Cohort / File(s) Summary
Docker Configuration
docker/Dockerfile.ci
Added setup.py to the COPY instruction for Megatron-LM submodule, now copying both setup.py and pyproject.toml.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

r0.3.0

Suggested reviewers

  • chtruong814
  • thomasdhc
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Test Results For Major Changes ⚠️ Warning Commit involves 900 files with 231,919 lines added with misleading commit message and no test results, performance metrics, or convergence validation provided. PR author must provide comprehensive test results, performance benchmarks, convergence validation, and accurate commit message reflecting the scope of 900-file changes.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'build: Add setup.py to first layers' directly matches the change: copying setup.py to earlier Docker build layers for caching optimization.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/build/compile-helper-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ko3n1g ko3n1g merged commit 09b614d into main Feb 18, 2026
18 of 19 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/build/compile-helper-2 branch February 18, 2026 00:23
pengdurice pushed a commit to pengdurice/Megatron-Bridge that referenced this pull request Feb 24, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: pengdurice <pengduhit@gmail.com>
copy-pr-bot bot pushed a commit that referenced this pull request Mar 19, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants