Skip to content

cp: build: Compile dataset helper#2415

Merged
ko3n1g merged 1 commit intor0.3.0from
ko3n1g/cp/28d7381c7ea9d22c6fdeae911fef591d58fa2d7c
Feb 17, 2026
Merged

cp: build: Compile dataset helper#2415
ko3n1g merged 1 commit intor0.3.0from
ko3n1g/cp/28d7381c7ea9d22c6fdeae911fef591d58fa2d7c

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 17, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

  • Chores
    • Enhanced Docker continuous integration build configuration to include additional dataset-related support files within the container image. These infrastructure improvements strengthen build reliability and consistency, ensuring comprehensive component availability during testing and deployment phases.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Feb 17, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ko3n1g ko3n1g marked this pull request as ready for review February 17, 2026 19:58
@ko3n1g ko3n1g requested a review from a team as a code owner February 17, 2026 19:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 17, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Adds two Megatron-LM dataset-related files (datasets/Makefile and datasets/helpers.cpp) to the Docker CI image build context by copying them to /opt/Megatron-Bridge/3rdparty/Megatron-LM/megatron/core/datasets/.

Changes

Cohort / File(s) Summary
Docker CI Build Context
docker/Dockerfile.ci
Added COPY instruction to include datasets/Makefile and datasets/helpers.cpp files into the CI image at the Megatron-LM datasets directory.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

r0.3.0, Run CICD, cherry-pick

Suggested reviewers

  • thomasdhc
  • maanug-nv
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references a build-related change for a dataset helper, which aligns with the actual changeset of adding dataset-related files (datasets/Makefile and datasets/helpers.cpp) to the Docker build context, though the wording is somewhat unclear.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Results For Major Changes ✅ Passed PR contains only minor changes: a single line addition to Dockerfile copying dataset-related files into Docker build context. Per custom check criteria, test results documentation is required only for major changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/cp/28d7381c7ea9d22c6fdeae911fef591d58fa2d7c

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ko3n1g ko3n1g merged commit 1f82df6 into r0.3.0 Feb 17, 2026
13 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/cp/28d7381c7ea9d22c6fdeae911fef591d58fa2d7c branch February 17, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants