Skip to content

cp: chore: Expose custom bash cmds (2237) into r0.3.0#2243

Merged
ko3n1g merged 1 commit intor0.3.0from
cherry-pick-2237-r0.3.0
Feb 6, 2026
Merged

cp: chore: Expose custom bash cmds (2237) into r0.3.0#2243
ko3n1g merged 1 commit intor0.3.0from
cherry-pick-2237-r0.3.0

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 5, 2026

beep boop [🤖]: Hi @ko3n1g 👋,

we've cherry picked #2237 into  for you! 🚀

Please review and approve this cherry pick by your convenience!

Summary by CodeRabbit

  • New Features
    • Added -cb / --custom_bash_cmds command-line argument to accept comma-separated bash commands.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
@ko3n1g
Copy link
Copy Markdown
Contributor Author

ko3n1g commented Feb 5, 2026

/ok to test c411f15

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Feb 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

This PR adds a new CLI argument -cb/--custom_bash_cmds to accept comma-separated bash commands. The parameter is threaded through the setup_experiment module's main function and forwarded to the Slurm executor.

Changes

Cohort / File(s) Summary
CLI Argument Addition
scripts/performance/argument_parser.py
Added new Slurm CLI argument -cb/--custom_bash_cmds of type list_of_strings with an empty list default.
Parameter Threading
scripts/performance/setup_experiment.py
Added custom_bash_cmds parameter to the main() function signature and forwarded it through the slurm_executor() call and __main__ entry point.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: exposing custom bash commands feature (reference #2237) as a cherry-pick into the r0.3.0 branch, which aligns with the code additions in argument_parser.py and setup_experiment.py.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Test Results For Major Changes ✅ Passed PR adds CLI argument plumbing for custom_bash_cmds (10 lines, additive only). No logic modifications, algorithms altered, or performance-critical code changed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cherry-pick-2237-r0.3.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant