Skip to content

chore: Expose custom bash cmds#2237

Merged
ko3n1g merged 10 commits intomainfrom
ko3n1g/chore/expose-custom-bash-cmds
Feb 5, 2026
Merged

chore: Expose custom bash cmds#2237
ko3n1g merged 10 commits intomainfrom
ko3n1g/chore/expose-custom-bash-cmds

Conversation

@ko3n1g
Copy link
Copy Markdown
Contributor

@ko3n1g ko3n1g commented Feb 5, 2026

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

Summary by CodeRabbit

Release Notes

  • New Features
    • Added --custom_bash_cmds CLI option (short: -cb) to specify custom bash commands for performance experiments, enabling users to execute additional bash commands during job setup.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

The changes add support for custom bash commands in the performance testing framework by introducing a new CLI argument --custom_bash_cmds and propagating it through the setup_experiment module to the Slurm executor.

Changes

Cohort / File(s) Summary
CLI Argument Definition
scripts/performance/argument_parser.py
Added new --custom_bash_cmds / -cb argument accepting a comma-separated list of strings with default empty list.
Parameter Propagation
scripts/performance/setup_experiment.py
Updated main() function signature to accept custom_bash_cmds: List[str] parameter and propagated it to slurm_executor and __main__ invocations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: Expose custom bash cmds' directly relates to the main changeset, which adds a new custom_bash_cmds parameter across the performance scripts.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Test Results For Major Changes ✅ Passed PR exposes existing custom_bash_cmds feature by threading parameter through CLI and function signatures to already-implemented capability in slurm_executor.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ko3n1g/chore/expose-custom-bash-cmds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
f
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g added the r0.3.0 Cherry-pick label for r0.3.0 release branch label Feb 5, 2026
@ko3n1g ko3n1g merged commit 21379ca into main Feb 5, 2026
12 of 21 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/chore/expose-custom-bash-cmds branch February 5, 2026 18:29
ko3n1g added a commit that referenced this pull request Feb 5, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
sowmen pushed a commit to sowmen/Megatron-Bridge that referenced this pull request Feb 11, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: sowmen <sowmendipta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r0.3.0 Cherry-pick label for r0.3.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants