Skip to content

[Fix] gptoss yarn parameter #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yiakwy-xpu-ml-framework-team wants to merge 1 commit into from
Closed

[Fix] gptoss yarn parameter #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/megatron/bridge/models/gpt_oss/gpt_oss_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ class GPTOSSProvider(GPTModelProvider):
yarn_beta_fast: float = 32.0
yarn_beta_slow: float = 1.0
yarn_correction_range_round_to_int: bool = False
yarn_mscale: Optional[float] = None
yarn_mscale_all_dim: Optional[float] = None
yarn_mscale: Optional[float] = 1.0 # NOTE (yiakwy) : None
yarn_mscale_all_dim: Optional[float] = 1.0 # NOTE(yiakwy) : None

moe_router_topk: int = 4
moe_router_pre_softmax: bool = False
Expand Down
2 changes: 1 addition & 1 deletion src/megatron/bridge/training/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class DistributedInitConfig:
Make sure EP and CP aren't used with this option enabled.
"""

use_gloo_process_groups: bool = True
use_gloo_process_groups: bool = False # True NOTE (yiakwy)
Copy link
Contributor

@yaoyu-33 yaoyu-33 Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change? please attach a note in the comment if the change is necessary

Copy link
Author

@yiakwy-xpu-ml-framework-team yiakwy-xpu-ml-framework-team Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default gloo will be used to create TCP connection in CPU side.

But we don't need it. It should be assumed to be Flase.

Copy link
Author

@yiakwy-xpu-ml-framework-team yiakwy-xpu-ml-framework-team Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will roll back to True

"""If set, create Gloo process groups for communications."""

use_sharp: bool = False
Expand Down