[Fix] gptoss yarn parameter#1491
[Fix] gptoss yarn parameter#1491yiakwy-xpu-ml-framework-team wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
|
Doctor sergiopperez Could you have a look at this ? This is essentail for support of GptOSS traininig D. |
9877f5f to
0d06277
Compare
| """ | ||
|
|
||
| use_gloo_process_groups: bool = True | ||
| use_gloo_process_groups: bool = False # True NOTE (yiakwy) |
There was a problem hiding this comment.
why is this change? please attach a note in the comment if the change is necessary
There was a problem hiding this comment.
by default gloo will be used to create TCP connection in CPU side.
But we don't need it. It should be assumed to be Flase.
There was a problem hiding this comment.
Will roll back to True
|
updated version of this PR at #2413 |
|
Sorry, I misinterpreted some settings in MCore , so #2413 is invalid. but |
What does this PR do ?
Fix gptoss GptOSS yarn default parameters when passing them to mcore where mcore does not accept None as valid vlaues.
Changelog
GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information