Skip to content

Cherry pick 1216 r0.2.0 - #1318

Closed
adityavavreNVDA wants to merge 63 commits into
mainfrom
cherry-pick-1216-r0.2.0
Closed

Cherry pick 1216 r0.2.0#1318
adityavavreNVDA wants to merge 63 commits into
mainfrom
cherry-pick-1216-r0.2.0

Conversation

@adityavavreNVDA

Copy link
Copy Markdown
Contributor

What does this PR do ?

Cherry pick #1216 into r0.2.0

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

chtruong814 and others added 30 commits October 21, 2025 23:47
* chore(beep boop 🤖): Bump `uv.lock` (main) (2025-10-16)



* expose eos property on tokenizers



* dev branch fix for linear attention type spec arg (#987)

* chore(beep boop 🤖): Bump `uv.lock` (main) (2025-10-15)



* explicitly set kwargs in mlm compat gpt specs



* support existing checkpoint without linear attn arg



---------





* fix tests for mlm compat to use kwargs



---------

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: ko3n1g <16716991+ko3n1g@users.noreply.github.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Co-authored-by: Maanu Grover <109391026+maanug-nv@users.noreply.github.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: ko3n1g <16716991+ko3n1g@users.noreply.github.com>
…1030) (#1034)

* add override kwargs



* add test



---------

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Maanu Grover <109391026+maanug-nv@users.noreply.github.com>
* qwen3 finetuning configs



* qwen3 finetuning configs



* qwen3 finetune



* qwen3 finetune recipes



* updates



* revert changes to gpt step



* address feedback



* add load dir



---------

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
)

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
* make nemotronh recipe imports consistent



* rm extra



---------

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
* support loading checkpoints from a given step



* support loading checkpoints from a given step



* add config test



* fix tests



---------

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
* enable ep and etp in bridge code



* fix embeddings_are_tied issues



* fix tp + pp, expert number issue



* lint



* add gpt-oss provider



* add gpt oss bridge placeholder



* unit test fix



* naming fix



* lint



* Update src/megatron/bridge/models/conversion/param_mapping.py




* address comments



* fix for hf to megatron to run



* finish hf import

* push current export code



* fix export



* fix export



* address comment



* fix row parallel bias



* fix expert weight export on multi gpus



* fix assertion



* fix config and clean up



* fix for ep and tp



* remove strict flag



* add pipeline dtype to ModelParallelKwargs



* fix ep=1



* pipeline dtype



* revert



* remove quantization option (import can handle both, export is always de-quantized)



* fix etp



* clean up



* add tests



* fix conversion test



* linting



* address comments



* fix tensor shape for ep=1 for other moe models



* add recipes



* clean up

* lint

* add recipe test

* clean up



* address comment



* update test



---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Signed-off-by: Chen Cui <cxcui@alumni.cmu.edu>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Chen Cui <cxcui@alumni.cmu.edu>
Co-authored-by: yaoyu-33 <yaoyu.094@gmail.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
… `r0.2.0` (#1109)

Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Maanu Grover <109391026+maanug-nv@users.noreply.github.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
…1112)

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
….0` (#1107)

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
…ders (1004)` into `r0.2.0` (#1118)

Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yuzhong Wang <yuzhongw@nvidia.com>
Signed-off-by: Raghav Hrishikeshan Mukundan <rmukundan@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Raghav Hrishikeshan Mukundan <102543536+rhmukundan@users.noreply.github.com>
Signed-off-by: Ao Tang <aot@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Ao Tang <aot@nvidia.com>
…1173)

Signed-off-by: adityavavreNVDA <avavre@nvidia.com>
)

Signed-off-by: Asha Anoosheh <aanoosheh@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Asha Anoosheh <aanoosheh@nvidia.com>
chtruong814 and others added 4 commits November 11, 2025 13:15
…0.2.0` (#1293)

Signed-off-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: malay-nagda <malayn@nvidia.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Malay Nagda <malayn@nvidia.com>
Signed-off-by: Aditya Vavre <avavre@nvidia.com>
Signed-off-by: adityavavreNVDA <avavre@nvidia.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: adityavavreNVDA <avavre@nvidia.com>
Co-authored-by: Aditya Vavre <avavre@gcp-nrt-cs-001-login-001.cm.cluster>
@adityavavreNVDA
adityavavreNVDA requested a review from a team as a code owner November 12, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants