Make nemotronh recipe imports consistent with codebase - #1006
Merged
Conversation
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
Contributor
Author
|
/ok to test 54773be |
yaoyu-33
approved these changes
Oct 20, 2025
ananthsub
enabled auto-merge (squash)
October 20, 2025 18:27
maanug-nv
approved these changes
Oct 21, 2025
maanug-nv
left a comment
maanug-nv
left a comment
Contributor
There was a problem hiding this comment.
Looks great much simpler, thanks!
chtruong814
pushed a commit
that referenced
this pull request
Oct 21, 2025
* make nemotronh recipe imports consistent Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * rm extra Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
ananthsub
added a commit
that referenced
this pull request
Oct 22, 2025
* make nemotronh recipe imports consistent Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * rm extra Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
ananthsub
added a commit
that referenced
this pull request
Oct 23, 2025
* make nemotronh recipe imports consistent * rm extra --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
paul-gibbons
pushed a commit
to paul-gibbons/Megatron-Bridge
that referenced
this pull request
Oct 29, 2025
nv-mollys
pushed a commit
that referenced
this pull request
Oct 31, 2025
* make nemotronh recipe imports consistent Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * rm extra Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: mollys <mollys@mollys.nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow example of #607 and #895 for a consistent import structure. swapping out the model provider to use the bridge can come separately after this refactor