cp: docs: Docker install path, Python 3.13.14 refs, enroot GPU toolkit (#2725) into main - #2984
Merged
Conversation
Contributor
|
🌿 Preview your docs: https://nvidia-preview-cherry-pick-2725-main.docs.buildwithfern.com/nemo/gym Here are the markdown pages you've updated: |
kajalj22
force-pushed
the
cherry-pick-2725-main
branch
from
September 2, 2026 19:18
366c299 to
9d5f552
Compare
This was referenced Sep 2, 2026
Merged
kajalj22
force-pushed
the
cherry-pick-2629-main
branch
from
September 2, 2026 20:26
e4b4872 to
8903575
Compare
kajalj22
added a commit
that referenced
this pull request
Sep 2, 2026
…laimer (#2629) into main (#2985) ## Summary - Cherry-pick of #2629 from `r0.5.1` into `main`. **Stack position 2 of 5** — #2547 (position 1) merged as #2986. This is now next in line, rebased directly onto `main`. - Adds a "Cloned and Modified Components" section to `ATTRIBUTIONS.md` covering PinchBench (cloned & patched at image build, MIT-licensed). - Adds the NVIDIA retrieved-materials Notice and Disclaimer to `README.md`, required for containers that automatically retrieve external materials at runtime. - Addresses OSRB guidance items 10 and 11. Remaining stack (merge in this order): #2985 → #2984 → #2987 → #2983 ## Test plan - [ ] Confirm ATTRIBUTIONS.md and README.md render correctly Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…2725) - Document the pre-built NeMo Gym Docker image install path (`docker run`, including the `--entrypoint /bin/bash` override), per feedback that this was undocumented for v0.5.1 - Fix stale `Python 3.12` references across install/dev-setup docs to the repo's actual requirement, `3.13.14` - Install `nvidia-container-toolkit` in the image so enroot's NVIDIA hook (`/etc/enroot/hooks.d/98-nvidia.sh`) can find `nvidia-container-cli` and inject GPUs into enroot sandboxes Addresses issues raised against the v0.5.1 RC container: - `nvidia-container-cli` missing for the enroot GPU hook - Installation docs outdated for Docker usage --------- Signed-off-by: Kajal Jain <kajalj@nvidia.com>
kajalj22
force-pushed
the
cherry-pick-2725-main
branch
from
September 2, 2026 22:03
9d5f552 to
ed14786
Compare
github-actions
Bot
added
the
sla:triage-overdue
kajalj22
added
the
r0.6.0
Contributor
Author
|
/ok to test 280492c |
kajalj22
added a commit
that referenced
this pull request
Sep 4, 2026
…2987) ## Summary - Cherry-pick of #2731 from `r0.5.1` into `main`. **Stack position 4 of 5** — #2547, #2629, #2725 (positions 1-3) merged as #2986, #2985, #2984. This is now next in line, rebased directly onto `main`. - Adds the frozen `fern/versions/v0.5.1/` docs snapshot (and `fern/versions/v0.5.1.yml`) for the v0.5.1 GA release, mirroring how prior GA versions (v0.5.0, v0.4.0, ...) got their own version snapshot in the docs site. - Also inserts the v0.5.1 accordion into `release-notes.mdx`, between the newer v0.6.0 entry (already on `main`) and v0.5.0. - Note on PR title: intentionally omits `(#2731)` — the release-branch auto-cherrypick automation (`cherry-pick-release-commit.yml`) naively grabs the *first* `(#NNNN)` in the squash-merge commit subject to resolve "which PR is this". Embedding the original PR number in the title broke that lookup for #2984/#2985/#2986 (see #3091/#3092 for the manual r0.6.0 backfills). Keeping this title number-free lets the automation resolve the real PR (#2987) and auto-create the r0.6.0 cherry-pick. Remaining stack (merge in this order): #2987 → #2983 ## Test plan - [ ] Confirm fern docs build picks up the new v0.5.1 version and the version switcher shows it - [ ] `tests/unit_tests/test_fern_docs_links.py` passes Signed-off-by: Kajal Jain <kajalj@nvidia.com>
kajalj22
added a commit
that referenced
this pull request
Sep 5, 2026
…laimer (#2629) into main (#2985) ## Summary - Cherry-pick of #2629 from `r0.5.1` into `main`. **Stack position 2 of 5** — #2547 (position 1) merged as #2986. This is now next in line, rebased directly onto `main`. - Adds a "Cloned and Modified Components" section to `ATTRIBUTIONS.md` covering PinchBench (cloned & patched at image build, MIT-licensed). - Adds the NVIDIA retrieved-materials Notice and Disclaimer to `README.md`, required for containers that automatically retrieve external materials at runtime. - Addresses OSRB guidance items 10 and 11. Remaining stack (merge in this order): #2985 → #2984 → #2987 → #2983 ## Test plan - [ ] Confirm ATTRIBUTIONS.md and README.md render correctly Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
…laimer (#2629) into main (#2985) ## Summary - Cherry-pick of #2629 from `r0.5.1` into `main`. **Stack position 2 of 5** — #2547 (position 1) merged as #2986. This is now next in line, rebased directly onto `main`. - Adds a "Cloned and Modified Components" section to `ATTRIBUTIONS.md` covering PinchBench (cloned & patched at image build, MIT-licensed). - Adds the NVIDIA retrieved-materials Notice and Disclaimer to `README.md`, required for containers that automatically retrieve external materials at runtime. - Addresses OSRB guidance items 10 and 11. Remaining stack (merge in this order): #2985 → #2984 → #2987 → #2983 ## Test plan - [ ] Confirm ATTRIBUTIONS.md and README.md render correctly Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
#2725) into main (#2984) ## Summary - Cherry-pick of #2725 from `r0.5.1` into `main`. **Stack position 3 of 5** — #2547 and #2629 (positions 1-2) merged as #2986 and #2985. This is now next in line, rebased directly onto `main`. - Updates installation docs: Python 3.12 → 3.13.14 references, adds the pre-built NeMo Gym NGC container instructions (replacing the outdated NeMo RL v0.4.0 container guidance), and adds the `nvidia-container-toolkit` install step + docs for the enroot GPU hook. Signed-off-by: Kajal Jain <kajalj@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
…2987) ## Summary - Cherry-pick of #2731 from `r0.5.1` into `main`. **Stack position 4 of 5** — #2547, #2629, #2725 (positions 1-3) merged as #2986, #2985, #2984. This is now next in line, rebased directly onto `main`. - Adds the frozen `fern/versions/v0.5.1/` docs snapshot (and `fern/versions/v0.5.1.yml`) for the v0.5.1 GA release, mirroring how prior GA versions (v0.5.0, v0.4.0, ...) got their own version snapshot in the docs site. - Also inserts the v0.5.1 accordion into `release-notes.mdx`, between the newer v0.6.0 entry (already on `main`) and v0.5.0. - Note on PR title: intentionally omits `(#2731)` — the release-branch auto-cherrypick automation (`cherry-pick-release-commit.yml`) naively grabs the *first* `(#NNNN)` in the squash-merge commit subject to resolve "which PR is this". Embedding the original PR number in the title broke that lookup for #2984/#2985/#2986 (see #3091/#3092 for the manual r0.6.0 backfills). Keeping this title number-free lets the automation resolve the real PR (#2987) and auto-create the r0.6.0 cherry-pick. Remaining stack (merge in this order): #2987 → #2983 ## Test plan - [ ] Confirm fern docs build picks up the new v0.5.1 version and the version switcher shows it - [ ] `tests/unit_tests/test_fern_docs_links.py` passes Signed-off-by: Kajal Jain <kajalj@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
r0.5.1intomain. Stack position 3 of 5 — docs: expand ATTRIBUTIONS.md to full 167-package inventory #2547 and docs(legal): PinchBench modified-component notice and NVIDIA disclaimer #2629 (positions 1-2) merged as cp: docs: expand ATTRIBUTIONS.md to full 167-package inventory (#2547) into main #2986 and cp: docs(legal): PinchBench modified-component notice and NVIDIA disclaimer (#2629) into main #2985. This is now next in line, rebased directly ontomain.nvidia-container-toolkitinstall step + docs for the enroot GPU hook.