cp: fix(docker): drop --ldconfig arg from enroot NVIDIA hook into main - #2983
Merged
Conversation
kajalj22
force-pushed
the
cherry-pick-2781-main
branch
from
September 2, 2026 19:18
4435714 to
9a0b0ff
Compare
This was referenced Sep 2, 2026
Merged
Merged
Contributor
kajalj22
added a commit
that referenced
this pull request
Sep 2, 2026
…laimer (#2629) into main (#2985) ## Summary - Cherry-pick of #2629 from `r0.5.1` into `main`. **Stack position 2 of 5** — #2547 (position 1) merged as #2986. This is now next in line, rebased directly onto `main`. - Adds a "Cloned and Modified Components" section to `ATTRIBUTIONS.md` covering PinchBench (cloned & patched at image build, MIT-licensed). - Adds the NVIDIA retrieved-materials Notice and Disclaimer to `README.md`, required for containers that automatically retrieve external materials at runtime. - Addresses OSRB guidance items 10 and 11. Remaining stack (merge in this order): #2985 → #2984 → #2987 → #2983 ## Test plan - [ ] Confirm ATTRIBUTIONS.md and README.md render correctly Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
sla:triage-overdue
kajalj22
force-pushed
the
cherry-pick-2731-main
branch
from
September 4, 2026 18:17
544ac23 to
9af4491
Compare
kajalj22
changed the title
kajalj22
added a commit
that referenced
this pull request
Sep 4, 2026
…2987) ## Summary - Cherry-pick of #2731 from `r0.5.1` into `main`. **Stack position 4 of 5** — #2547, #2629, #2725 (positions 1-3) merged as #2986, #2985, #2984. This is now next in line, rebased directly onto `main`. - Adds the frozen `fern/versions/v0.5.1/` docs snapshot (and `fern/versions/v0.5.1.yml`) for the v0.5.1 GA release, mirroring how prior GA versions (v0.5.0, v0.4.0, ...) got their own version snapshot in the docs site. - Also inserts the v0.5.1 accordion into `release-notes.mdx`, between the newer v0.6.0 entry (already on `main`) and v0.5.0. - Note on PR title: intentionally omits `(#2731)` — the release-branch auto-cherrypick automation (`cherry-pick-release-commit.yml`) naively grabs the *first* `(#NNNN)` in the squash-merge commit subject to resolve "which PR is this". Embedding the original PR number in the title broke that lookup for #2984/#2985/#2986 (see #3091/#3092 for the manual r0.6.0 backfills). Keeping this title number-free lets the automation resolve the real PR (#2987) and auto-create the r0.6.0 cherry-pick. Remaining stack (merge in this order): #2987 → #2983 ## Test plan - [ ] Confirm fern docs build picks up the new v0.5.1 version and the version switcher shows it - [ ] `tests/unit_tests/test_fern_docs_links.py` passes Signed-off-by: Kajal Jain <kajalj@nvidia.com>
## Summary - Patches `/etc/enroot/hooks.d/98-nvidia.sh` at build time to drop the `--ldconfig=@...` arg passed to `nvidia-container-cli` - Fixes nested enroot GPU sandboxes failing with: ``` nvidia-container-cli: ldcache error: process /usr/sbin/ldconfig.real failed with error code: 1 [ERROR] /etc/enroot/hooks.d/98-nvidia.sh exited with return code 1 ``` ## Context Nested enroot GPU passthrough under Slurm/pyxis fails under some GPU cgroup configurations because `nvidia-container-cli`'s `--ldconfig=@...` flag makes it re-exec the sandbox's `ldconfig` to regenerate `ld.so.cache`, and that regeneration step crashes. Dropping the flag makes it reuse the existing cache instead, which avoids the failure. Reproduces with any container doing nested enroot GPU passthrough on affected clusters, not something specific to Gym. ## Test plan - [x] Verified live on a cluster hitting this failure: with this patch applied to a running container's hook script, `nvidia-smi` succeeds inside a nested `enroot` sandbox (GPU visible) — previously failed at the hook step with the exact error above - [ ] Verify a full image build applies the patch correctly (`grep` assertion in the Dockerfile fails the build loudly if the hook content changes upstream and the sed no longer matches) - [ ] Re-run the real `gym env start` + `mini_swe_agent_2` + enroot repro from the original bug report against the rebuilt image --------- Signed-off-by: Kajal Jain <kajalj@nvidia.com>
kajalj22
force-pushed
the
cherry-pick-2781-main
branch
from
September 4, 2026 18:48
9a0b0ff to
a839647
Compare
Contributor
Author
|
/ok to test a839647 |
Contributor
Author
|
/ok to test bc0ca45 |
kajalj22
added
the
r0.6.0
balasaajay
approved these changes
Sep 4, 2026
github-actions
Bot
removed
the
sla:triage-overdue
kajalj22
added a commit
that referenced
this pull request
Sep 5, 2026
…o main (2983)` into `r0.6.0` (#3120) beep boop [🤖]: Hi @kajalj22 👋, we've cherry picked #2983 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Kajal Jain <kajalj@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: kajalj22 <kajalj@nvidia.com>
kajalj22
added a commit
that referenced
this pull request
Sep 5, 2026
…laimer (#2629) into main (#2985) ## Summary - Cherry-pick of #2629 from `r0.5.1` into `main`. **Stack position 2 of 5** — #2547 (position 1) merged as #2986. This is now next in line, rebased directly onto `main`. - Adds a "Cloned and Modified Components" section to `ATTRIBUTIONS.md` covering PinchBench (cloned & patched at image build, MIT-licensed). - Adds the NVIDIA retrieved-materials Notice and Disclaimer to `README.md`, required for containers that automatically retrieve external materials at runtime. - Addresses OSRB guidance items 10 and 11. Remaining stack (merge in this order): #2985 → #2984 → #2987 → #2983 ## Test plan - [ ] Confirm ATTRIBUTIONS.md and README.md render correctly Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Kajal Jain <kajalj@nvidia.com>
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
…laimer (#2629) into main (#2985) ## Summary - Cherry-pick of #2629 from `r0.5.1` into `main`. **Stack position 2 of 5** — #2547 (position 1) merged as #2986. This is now next in line, rebased directly onto `main`. - Adds a "Cloned and Modified Components" section to `ATTRIBUTIONS.md` covering PinchBench (cloned & patched at image build, MIT-licensed). - Adds the NVIDIA retrieved-materials Notice and Disclaimer to `README.md`, required for containers that automatically retrieve external materials at runtime. - Addresses OSRB guidance items 10 and 11. Remaining stack (merge in this order): #2985 → #2984 → #2987 → #2983 ## Test plan - [ ] Confirm ATTRIBUTIONS.md and README.md render correctly Signed-off-by: Kajal Jain <kajalj@nvidia.com> Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
…2987) ## Summary - Cherry-pick of #2731 from `r0.5.1` into `main`. **Stack position 4 of 5** — #2547, #2629, #2725 (positions 1-3) merged as #2986, #2985, #2984. This is now next in line, rebased directly onto `main`. - Adds the frozen `fern/versions/v0.5.1/` docs snapshot (and `fern/versions/v0.5.1.yml`) for the v0.5.1 GA release, mirroring how prior GA versions (v0.5.0, v0.4.0, ...) got their own version snapshot in the docs site. - Also inserts the v0.5.1 accordion into `release-notes.mdx`, between the newer v0.6.0 entry (already on `main`) and v0.5.0. - Note on PR title: intentionally omits `(#2731)` — the release-branch auto-cherrypick automation (`cherry-pick-release-commit.yml`) naively grabs the *first* `(#NNNN)` in the squash-merge commit subject to resolve "which PR is this". Embedding the original PR number in the title broke that lookup for #2984/#2985/#2986 (see #3091/#3092 for the manual r0.6.0 backfills). Keeping this title number-free lets the automation resolve the real PR (#2987) and auto-create the r0.6.0 cherry-pick. Remaining stack (merge in this order): #2987 → #2983 ## Test plan - [ ] Confirm fern docs build picks up the new v0.5.1 version and the version switcher shows it - [ ] `tests/unit_tests/test_fern_docs_links.py` passes Signed-off-by: Kajal Jain <kajalj@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
jkyi-nvidia
pushed a commit
that referenced
this pull request
Sep 11, 2026
#2983) ## Summary - Cherry-pick of #2781 from `r0.5.1` into `main`. **Stack position 5 of 5** — all prior positions merged. This is the last one, rebased directly onto `main`. - Patches `/etc/enroot/hooks.d/98-nvidia.sh` at build time to drop the `--ldconfig=@...` arg passed to `nvidia-container-cli`, fixing nested enroot GPU sandboxes failing at the hook step under some GPU cgroup configurations. Signed-off-by: Kajal Jain <kajalj@nvidia.com> Signed-off-by: Junkeun Yi <jkyi@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
r0.5.1intomain. Stack position 5 of 5 — all prior positions merged. This is the last one, rebased directly ontomain./etc/enroot/hooks.d/98-nvidia.shat build time to drop the--ldconfig=@...arg passed tonvidia-container-cli, fixing nested enroot GPU sandboxes failing at the hook step under some GPU cgroup configurations.