docs: link training tutorials under the /tutorials/ section prefix - #2317
Merged
ananthsub merged 1 commit intoAug 4, 2026
Merged
Conversation
Contributor
ananthsub
marked this pull request as ready for review
August 4, 2026 15:17
lbliii
approved these changes
Aug 4, 2026
fern/versions/main.yml puts training-tutorials and evaluation-tutorials in the
same `section: Tutorials`, so both publish under /tutorials/. Evaluation
tutorials are already linked that way; training tutorials were not.
/nemo/gym/tutorials/training-tutorials/nemo-rl-grpo/ 200
/nemo/gym/training-tutorials/nemo-rl-grpo/ 308 -> /tutorials/...
The old form works, but only because Fern redirects it, and having two sibling
folders under one section linked two different ways makes the prefix look
optional. It is not: /evaluation-tutorials/... has no redirect and returns 404.
Rewrites 52 links across 23 pages in `latest`. Every distinct target was checked
against the published site and returns 200. Frozen versions are unchanged.
The new check in test_fern_docs_links.py asserts no link omits the prefix rather
than pinning an exact count, since a fixed total would need editing whenever a
tutorial gains a cross-reference.
Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
ananthsub/docs-tutorials-slug
branch
from
August 4, 2026 19:07
d74c56c to
e46fba7
Compare
ananthsub
enabled auto-merge (squash)
August 4, 2026 19:07
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…VIDIA-NeMo#2317) `fern/versions/main.yml` puts `training-tutorials` and `evaluation-tutorials` in the same `section: Tutorials`, so both publish under `/tutorials/`. Evaluation tutorials are already linked that way. Training tutorials are not. Against the published site: ``` /nemo/gym/tutorials/training-tutorials/nemo-rl-grpo/ 200 /nemo/gym/training-tutorials/nemo-rl-grpo/ 308 -> /tutorials/training-tutorials/nemo-rl-grpo /nemo/gym/tutorials/evaluation-tutorials/evalplus/ 200 /nemo/gym/evaluation-tutorials/evalplus/ 404 ``` The old training form works, but only because Fern redirects it. The evaluation form has no such redirect. Having two sibling folders under one section linked two different ways makes the prefix look optional, and it isn't Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fern/versions/main.ymlputstraining-tutorialsandevaluation-tutorialsin the samesection: Tutorials, so both publish under/tutorials/. Evaluation tutorials are already linked that way. Training tutorials are not.Against the published site:
The old training form works, but only because Fern redirects it. The evaluation form has no such redirect. Having two sibling folders under one section linked two different ways makes the prefix look optional, and it isn't