docs: link Add a Benchmark by path instead of absolute URL - #2316
Merged
ananthsub merged 1 commit intoAug 5, 2026
Merged
Conversation
Contributor
|
🌿 Preview your docs: https://nvidia-preview-ananthsub-docs-agent-skills-link.docs.buildwithfern.com/nemo/gym Here are the markdown pages you've updated: |
ananthsub
added
documentation
ananthsub
marked this pull request as ready for review
August 4, 2026 15:16
ananthsub
marked this pull request as draft
August 4, 2026 15:19
ananthsub
marked this pull request as ready for review
August 4, 2026 15:26
github-actions
Bot
added
the
sla:review-overdue
anwithk
approved these changes
Aug 5, 2026
ananthsub
force-pushed
the
ananthsub/docs-agent-skills-link
branch
from
August 5, 2026 18:38
3938d75 to
51ad84c
Compare
ananthsub
enabled auto-merge (squash)
August 5, 2026 18:38
contribute/agent-skills.mdx linked to the Add a Benchmark page with a full docs.nvidia.com URL that carries no version slug. The URL resolves, but it drops readers on the default version regardless of which version they were reading. The two bullets on either side of it already use relative paths. Adds a check to test_fern_docs_links.py that flags absolute docs.nvidia.com links in `latest` pages. Prose mentions of the domain are not matched; the check only looks at markdown link targets and href attributes. The same link exists in fern/versions/v0.4.0/pages/contribute/agent-skills.mdx. That version is frozen, so it is left alone and the check is scoped to `latest`. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
ananthsub/docs-agent-skills-link
branch
from
August 5, 2026 18:39
51ad84c to
ea0e8bd
Compare
ananthsub
added a commit
that referenced
this pull request
Aug 5, 2026
…)` into `r0.5.0` (#2358) beep boop [🤖]: Hi @ananthsub 👋, we've cherry picked #2316 into for you! 🚀 Please review and approve this cherry pick by your convenience! Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com> Co-authored-by: Ananth Subramaniam <ansubramania@nvidia.com>
OlegSudakov
pushed a commit
to OlegSudakov/Gym
that referenced
this pull request
Aug 7, 2026
…Mo#2316) `contribute/agent-skills.mdx` links to the Add a Benchmark page with a full `docs.nvidia.com` URL that carries no version slug. The URL resolves (200), so nothing is broken, but it drops readers on the default version regardless of which version they were reading. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contribute/agent-skills.mdxlinks to the Add a Benchmark page with a fulldocs.nvidia.comURL that carries no version slug. The URL resolves (200), so nothing is broken, but it drops readers on the default version regardless of which version they were reading.