fix: make code-freeze next-version pre-release/dev tags configurable - #487
Merged
Conversation
The bump-next-version job hardcoded NEXT_PRERELEASE=rc0 and NEXT_DEV=dev0, re-introducing an rc0 tag on main for repos that moved to clean semver (e.g. Export-Deploy dropped rc0 in favor of dynamic git versioning), forcing a manual revert of the bump PR. - Add `next-pre-release` (default `rc0`) and `next-dev` (default `dev0`) inputs - Compose the version string conditionally so empty tags don't leave stray dots Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
thomasdhc
approved these changes
Jun 3, 2026
This was referenced Jun 3, 2026
ko3n1g
added a commit
to NVIDIA-NeMo/Evaluator
that referenced
this pull request
Jun 3, 2026
<details><summary>Claude summary</summary> ## Background / motivation - Bring this repo's `release-freeze.yml` in line with the rest of the NVIDIA-NeMo/* fleet on the latest tag of the shared `_code_freeze.yml` reusable workflow. - `v1.4.2` carries the fix that makes the bumped next-version pre-release/dev tags configurable, so a code freeze no longer re-introduces an `rc0` pre-release tag on clean-semver repos (NVIDIA-NeMo/FW-CI-templates#487). ## What changed - Bump `NVIDIA-NeMo/FW-CI-templates/.github/workflows/_code_freeze.yml` from `v0.86.0` → `v1.4.2`. ## Details - `.github/workflows/release-freeze.yml:37` — version pin updated. ## Tested - N/A; manual workflow is exercised on `release-freeze` dispatch. </details> --------- Signed-off-by: oliver könig <okoenig@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude summary
Background / motivation
bump-next-versionjob in_code_freeze.ymlhardcodedNEXT_PRERELEASE=rc0andNEXT_DEV=dev0.rc0tag onmainevery freeze. Export-Deploy droppedrc0in favor of dynamic git versioning (PRE_RELEASE = "", build: drop rc0 pre-release tag and add dynamic git versioning Export-Deploy#648), but the freeze bumpedmainback to0.7.0rc0— forcing a manual revert of the bump PR (Version bump to0.7.0rc0.dev0Export-Deploy#703, commit9dde413).package_info.pyalso has noDEVfield, sodev0only ever surfaced in the branch name / PR title / version output (0.7.0rc0.dev0) while the file said0.7.0rc0— a second inconsistency.What changed
next-pre-release(defaultrc0) andnext-dev(defaultdev0).next-devdoesn't leave a trailing..Details
.github/workflows/_code_freeze.yml:workflow_callinputsnext-pre-release/next-dev— defaults preserve the currentrc0/dev0behavior, so no existing consumer is affected.bump-versionstep via theenv:block (NEXT_PRERELEASE,NEXT_DEV) instead of hardcoded shell assignments.NEXT_VERSIONis built asMAJOR.MINOR.PATCH<pre>and.<dev>is appended only whennext-devis non-empty. Used for both thehatch__version__rewrite and theversionoutput.Example
A clean-semver repo (no
rc0, nodevfield) opts in from its caller workflow:Resulting next-version composition:
next-pre-releasenext-devrc0(default)dev0(default)0.7.0rc0.dev0""""0.7.0rc0""0.7.0rc0""dev00.7.0.dev0Tested
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/_code_freeze.yml'))"→ valid YAML.🤖 Generated with Claude Code