Skip to content

chore: bump _code_freeze workflow to v1.4.2 - #219

Merged
ko3n1g merged 3 commits into
mainfrom
ko3n1g/chore/bump-code-freeze-v1.4.1
Jun 9, 2026
Merged

chore: bump _code_freeze workflow to v1.4.2#219
ko3n1g merged 3 commits into
mainfrom
ko3n1g/chore/bump-code-freeze-v1.4.1

Conversation

@ko3n1g

@ko3n1g ko3n1g commented Jun 3, 2026

Copy link
Copy Markdown
Contributor
Claude summary

Background / motivation

What changed

  • Bump NVIDIA-NeMo/FW-CI-templates/.github/workflows/_code_freeze.yml from v0.86.0v1.4.2.

Details

  • .github/workflows/release-freeze.yml:37 — version pin updated.

Tested

  • N/A; manual workflow is exercised on release-freeze dispatch.

Signed-off-by: oliver könig <okoenig@nvidia.com>
@greptile-apps

greptile-apps Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the shared _code_freeze.yml reusable workflow pin from v0.86.0 to v1.4.2 and opts this repo into the new configurable pre-release/dev-tag behaviour introduced in that release.

  • Version pin updated on line 37: NVIDIA-NeMo/FW-CI-templates/.github/workflows/_code_freeze.yml@v0.86.0@v1.4.2.
  • Two new inputs added (next-pre-release: \"\" and next-dev: \"\"), explicitly disabling the automatic rc0/dev tag bump so clean-semver releases stay clean after a freeze dispatch.

Confidence Score: 5/5

Safe to merge — the change is a one-line version pin update plus two explicit empty-string inputs that opt out of unwanted pre-release tag behaviour.

The change touches only the reusable workflow reference and adds two well-understood configuration inputs. The new inputs explicitly pass empty strings to disable automatic rc0/dev tag insertion, which matches the stated intent. No logic changes, no secret handling modifications, and no other workflows are affected.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release-freeze.yml Bumps the reusable _code_freeze.yml workflow from v0.86.0 to v1.4.2 and explicitly sets next-pre-release and next-dev to empty strings to prevent spurious pre-release tags after a code freeze.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant CFT as FW-CI-templates<br/>_code_freeze.yml@v1.4.2
    participant Repo as emerging-optimizers

    Dev->>GH: workflow_dispatch (release-type, freeze-commit, dry-run)
    GH->>CFT: "call reusable workflow next-pre-release="", next-dev="""
    CFT->>Repo: create release branch
    CFT->>Repo: bump version (no rc0 / dev tag added)
    CFT->>Dev: Slack notification via SLACK_RELEASE_ENDPOINT
Loading

Reviews (2): Last reviewed commit: "chore: set `next-pre-release` and `next-..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Test Results

   54 files  ±0    116 suites  ±0   1m 32s ⏱️ -9s
1 102 tests ±0  1 102 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 455 runs  ±0  2 455 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 56d44e7. ± Comparison against base commit ed176db.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g changed the title chore: bump _code_freeze workflow to v1.4.1 chore: bump _code_freeze workflow to v1.4.2 Jun 3, 2026
Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g
ko3n1g merged commit cf7598c into main Jun 9, 2026
25 checks passed
@ko3n1g
ko3n1g deleted the ko3n1g/chore/bump-code-freeze-v1.4.1 branch June 9, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants