Remove duplicate deep researcher tests

[tanleach]

Overview

#406 forward merge retained both versions of three tests, causing Ruff F811. This removes the older 105-line duplicate block and retains the newer caplog-enhanced definitions. There is no production behavior change.

DCO sign-off for the squash commit

Signed-off-by: Tanner Leach tleach@nvidia.com

Validation

• uv run ruff check tests/aiq_agent/agents/deep_researcher/test_agent.py (passed)

• uv run ruff format --check tests/aiq_agent/agents/deep_researcher/test_agent.py (1 file already formatted)

• uv run pytest tests/aiq_agent/agents/deep_researcher/test_agent.py (55 passed)

• uv run ruff check . (passed)

• I ran the relevant local checks or explained why they are not applicable.

• I added or updated tests for behavior changes.
  Not applicable: this change only removes shadowed duplicate tests and introduces no behavior change.

• I updated documentation for user-facing or contributor-facing changes.
  Not applicable: this change has no user-facing or contributor-facing behavior.

• I confirmed this PR does not include secrets, credentials, or internal-only data.

• I certify this contribution under the Developer Certificate of Origin (DCO) and signed my commits with git commit -s or an equivalent sign-off.

• I replaced the DCO sign-off placeholder with my GitHub commit identity and kept the required angle brackets around the email address.

Where should reviewers start?

Start with the single deletion in tests/aiq_agent/agents/deep_researcher/test_agent.py; verify that the caplog-enhanced definition remains.

Related Issues

• Relates to Forward-merge release/2.2 into develop #406

Summary by CodeRabbit

• Tests
  • Added coverage to ensure empty source registries preserve sanitized answers and expose the correct error reason.
  • Verified that failed deep-research operations do not emit misleading error logs.
  • Confirmed citation verification rejects empty source selections before starting deep-research processing.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7d9eb656-d841-4e78-bdeb-d1beba7bd88a

📥 Commits

Reviewing files that changed from the base of the PR and between 9b40d59 and 4bf6839.

📒 Files selected for processing (1)

• tests/aiq_agent/agents/deep_researcher/test_agent.py

💤 Files with no reviewable changes (1)

• tests/aiq_agent/agents/deep_researcher/test_agent.py

---

Walkthrough

Deep researcher tests now verify sanitized empty-source error handling, suppress duplicate failure logging, and short-circuit deep-agent creation and invocation when citation verification is disabled with no selected sources.

Changes

Deep researcher test validation

Layer / File(s)	Summary
Empty-source error and orchestration validation tests/aiq_agent/agents/deep_researcher/test_agent.py	Tests capture logs while validating EmptySourceRegistryError, sanitized answers, suppressed subagent failure logs, and skipped deep-agent orchestration for empty source selections.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• NVIDIA-AI-Blueprints/aiq#284: Introduced the related citation-verification configuration and empty-selection handling.
• NVIDIA-AI-Blueprints/aiq#397: Introduced the related empty-source classification and sanitized error contract.
• NVIDIA-AI-Blueprints/aiq#405: Updated adjacent deep researcher tests for empty-source rejection and suppressed failure logging.

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Title check	❌ Error	The title is related, but it does not use the required Conventional Commits format or a valid type prefix.	Rewrite it as a Conventional Commit, e.g. test(deep-researcher): remove duplicate deep researcher tests.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description covers overview, DCO, validation, review start, and related issues, with only minor checklist items marked not applicable.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[AjayThorve]

/merge