Forward-merge release/2.2 into develop - #406
Merged
Merged
Conversation
## Summary Backports #397 to release/2.2, including actionable empty-source outcomes, safe async failure persistence, regression coverage, and artifact workflow documentation. ## Verification - Focused tests: 1,032 passed, 6 skipped - Ruff lint passed - Ruff format passed ## Summary by CodeRabbit * **New Features** * Research now returns consistent, actionable messaging for empty, unselected, unavailable, or no-results source conditions, including the relevant draft when available. * Async job status surfaces typed source-condition failures, and preserved reports remain accessible on failure. * Final report content is now emitted reliably as an output artifact for async flows. * **Documentation** * Updated the skills sandbox example to clarify persistence behavior. * Expanded REST API documentation for typed source-condition failures and report preservation. * **Tests** * Added and extended coverage for empty-source scenarios and async job status/report handling. * **Chores** * Updated link-check configuration to ignore an additional API reference URL. Authors: - Tanner Leach (https://github.com/tanleach) Approvers: - https://github.com/peterychang URL: #405
Author
|
SUCCESS - forward-merge complete. |
6 tasks
rapids-bot Bot
pushed a commit
that referenced
this pull request
Jul 29, 2026
#### Overview #406 forward merge retained both versions of three tests, causing Ruff F811. This removes the older 105-line duplicate block and retains the newer caplog-enhanced definitions. There is no production behavior change. #### DCO sign-off for the squash commit Signed-off-by: Tanner Leach <tleach@nvidia.com> #### Validation - `uv run ruff check tests/aiq_agent/agents/deep_researcher/test_agent.py` (passed) - `uv run ruff format --check tests/aiq_agent/agents/deep_researcher/test_agent.py` (1 file already formatted) - `uv run pytest tests/aiq_agent/agents/deep_researcher/test_agent.py` (55 passed) - `uv run ruff check .` (passed) - [x] I ran the relevant local checks or explained why they are not applicable. - [ ] I added or updated tests for behavior changes. Not applicable: this change only removes shadowed duplicate tests and introduces no behavior change. - [ ] I updated documentation for user-facing or contributor-facing changes. Not applicable: this change has no user-facing or contributor-facing behavior. - [x] I confirmed this PR does not include secrets, credentials, or internal-only data. - [x] I certify this contribution under the Developer Certificate of Origin (DCO) and signed my commits with `git commit -s` or an equivalent sign-off. - [x] I replaced the DCO sign-off placeholder with my GitHub commit identity and kept the required angle brackets around the email address. #### Where should reviewers start? Start with the single deletion in `tests/aiq_agent/agents/deep_researcher/test_agent.py`; verify that the caplog-enhanced definition remains. #### Related Issues - Relates to #406 ## Summary by CodeRabbit * **Tests** * Added coverage to ensure empty source registries preserve sanitized answers and expose the correct error reason. * Verified that failed deep-research operations do not emit misleading error logs. * Confirmed citation verification rejects empty source selections before starting deep-research processing. Authors: - Tanner Leach (https://github.com/tanleach) Approvers: - Ajay Thorve (https://github.com/AjayThorve) URL: #409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/2.2 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.