Forward-merge release/2.2 into develop - #350
Merged
Merged
Conversation
#### Overview Fixes AIQ-3571 by declaring the async deep-research flag on `DeepResearchWorkflowConfig` and safely reading it in the Dask job runner. Async jobs submitted with `config_domain_routing_and_skills.yml` now enter the deep-research workflow instead of failing with an `AttributeError`. A focused regression test covers enabled, disabled, absent, and missing-workflow cases. #### DCO sign-off for the squash commit Signed-off-by: Kyle Zheng <kyzheng@nvidia.com> #### Validation - [x] `.venv/bin/ruff check frontends/aiq_api/src/aiq_api/jobs/runner.py src/aiq_agent/agents/deep_researcher/register.py tests/aiq_agent/jobs/test_runner.py` — passed. - [x] `.venv/bin/ruff format --check frontends/aiq_api/src/aiq_api/jobs/runner.py src/aiq_agent/agents/deep_researcher/register.py tests/aiq_agent/jobs/test_runner.py` — 3 files already formatted. - [x] `.venv/bin/pytest tests/aiq_agent/jobs/test_runner.py -q` — 114 passed. - [x] Manual async regression with `config_domain_routing_and_skills.yml`: health and agent discovery passed; the Dask worker entered source routing and planning without the reported `AttributeError`. The report later stopped on unrelated model-provider 429 throttling. - [x] Tests cover the behavior change. - [x] Documentation is not required because this restores the existing configuration behavior. - [x] This PR contains no secrets, credentials, or internal-only data. - [x] The commit is DCO-signed and the squash sign-off above matches the GitHub identity. #### Where should reviewers start? Start with `_get_worker_function_type` in `frontends/aiq_api/src/aiq_api/jobs/runner.py` and its regression test in `tests/aiq_agent/jobs/test_runner.py`. #### Related Issues - Relates to AIQ-3571 ## Summary by CodeRabbit * **New Features** * Added an option to submit deep research tasks asynchronously instead of running them inline. * The option is disabled by default. * **Bug Fixes** * Improved compatibility with workflow configurations where the asynchronous research option is not specified. * Added coverage for enabled, disabled, missing, and empty workflow configurations. Authors: - Kyle Zheng (https://github.com/KyleZheng1284) Approvers: - Ajay Thorve (https://github.com/AjayThorve) URL: #347
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/2.2 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.