Skip to content

fix(async-deep-research): declare and safely read async flag - #347

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA-AI-Blueprints:release/2.2from
KyleZheng1284:codex/aiq-3571-async-deep-research
Jul 15, 2026
Merged

fix(async-deep-research): declare and safely read async flag#347
rapids-bot[bot] merged 2 commits into
NVIDIA-AI-Blueprints:release/2.2from
KyleZheng1284:codex/aiq-3571-async-deep-research

Conversation

@KyleZheng1284

@KyleZheng1284 KyleZheng1284 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Overview

Fixes AIQ-3571 by declaring the async deep-research flag on DeepResearchWorkflowConfig and safely reading it in the Dask job runner. Async jobs submitted with config_domain_routing_and_skills.yml now enter the deep-research workflow instead of failing with an AttributeError.

A focused regression test covers enabled, disabled, absent, and missing-workflow cases.

DCO sign-off for the squash commit

Signed-off-by: Kyle Zheng kyzheng@nvidia.com

Validation

  • .venv/bin/ruff check frontends/aiq_api/src/aiq_api/jobs/runner.py src/aiq_agent/agents/deep_researcher/register.py tests/aiq_agent/jobs/test_runner.py — passed.
  • .venv/bin/ruff format --check frontends/aiq_api/src/aiq_api/jobs/runner.py src/aiq_agent/agents/deep_researcher/register.py tests/aiq_agent/jobs/test_runner.py — 3 files already formatted.
  • .venv/bin/pytest tests/aiq_agent/jobs/test_runner.py -q — 114 passed.
  • Manual async regression with config_domain_routing_and_skills.yml: health and agent discovery passed; the Dask worker entered source routing and planning without the reported AttributeError. The report later stopped on unrelated model-provider 429 throttling.
  • Tests cover the behavior change.
  • Documentation is not required because this restores the existing configuration behavior.
  • This PR contains no secrets, credentials, or internal-only data.
  • The commit is DCO-signed and the squash sign-off above matches the GitHub identity.

Where should reviewers start?

Start with _get_worker_function_type in frontends/aiq_api/src/aiq_api/jobs/runner.py and its regression test in tests/aiq_agent/jobs/test_runner.py.

Related Issues

  • Relates to AIQ-3571

Summary by CodeRabbit

  • New Features

    • Added an option to submit deep research tasks asynchronously instead of running them inline.
    • The option is disabled by default.
  • Bug Fixes

    • Improved compatibility with workflow configurations where the asynchronous research option is not specified.
    • Added coverage for enabled, disabled, missing, and empty workflow configurations.

Signed-off-by: Kyle Zheng <kyzheng@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The deep research workflow configuration now defines an optional async-execution flag. Worker-function mapping handles workflows that omit the flag, and tests cover enabled, disabled, missing, and null workflow configurations.

Changes

Async deep research configuration

Layer / File(s) Summary
Async flag contract and worker mapping
src/aiq_agent/agents/deep_researcher/register.py, frontends/aiq_api/src/aiq_api/jobs/runner.py, tests/aiq_agent/jobs/test_runner.py
DeepResearchWorkflowConfig adds a default-disabled use_async_deep_research field; worker mapping reads the field safely; tests cover enabled, disabled, missing, and null workflow cases.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses Conventional Commits syntax and clearly summarizes the async deep-research configuration fix.
Description check ✅ Passed The description includes Overview, DCO sign-off, Validation, reviewer start point, and related issue details.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@KyleZheng1284
KyleZheng1284 marked this pull request as ready for review July 15, 2026 21:01
@KyleZheng1284
KyleZheng1284 requested a review from a team July 15, 2026 21:01
@KyleZheng1284

KyleZheng1284 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test a948a08

@KyleZheng1284 KyleZheng1284 changed the title Fix async deep research jobs for deep research workflows fix(async-deep-research): declare and safely read async flag Jul 15, 2026
@AjayThorve

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit bd91098 into NVIDIA-AI-Blueprints:release/2.2 Jul 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants