fix(async-deep-research): declare and safely read async flag - #347
Merged
rapids-bot[bot] merged 2 commits intoJul 15, 2026
Conversation
Signed-off-by: Kyle Zheng <kyzheng@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
WalkthroughThe deep research workflow configuration now defines an optional async-execution flag. Worker-function mapping handles workflows that omit the flag, and tests cover enabled, disabled, missing, and null workflow configurations. ChangesAsync deep research configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
KyleZheng1284
marked this pull request as ready for review
July 15, 2026 21:01
Contributor
Author
|
/ok to test a948a08 |
AjayThorve
approved these changes
Jul 15, 2026
Member
|
/merge |
rapids-bot
Bot
merged commit Jul 15, 2026
bd91098
into
NVIDIA-AI-Blueprints:release/2.2
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes AIQ-3571 by declaring the async deep-research flag on
DeepResearchWorkflowConfigand safely reading it in the Dask job runner. Async jobs submitted withconfig_domain_routing_and_skills.ymlnow enter the deep-research workflow instead of failing with anAttributeError.A focused regression test covers enabled, disabled, absent, and missing-workflow cases.
DCO sign-off for the squash commit
Signed-off-by: Kyle Zheng kyzheng@nvidia.com
Validation
.venv/bin/ruff check frontends/aiq_api/src/aiq_api/jobs/runner.py src/aiq_agent/agents/deep_researcher/register.py tests/aiq_agent/jobs/test_runner.py— passed..venv/bin/ruff format --check frontends/aiq_api/src/aiq_api/jobs/runner.py src/aiq_agent/agents/deep_researcher/register.py tests/aiq_agent/jobs/test_runner.py— 3 files already formatted..venv/bin/pytest tests/aiq_agent/jobs/test_runner.py -q— 114 passed.config_domain_routing_and_skills.yml: health and agent discovery passed; the Dask worker entered source routing and planning without the reportedAttributeError. The report later stopped on unrelated model-provider 429 throttling.Where should reviewers start?
Start with
_get_worker_function_typeinfrontends/aiq_api/src/aiq_api/jobs/runner.pyand its regression test intests/aiq_agent/jobs/test_runner.py.Related Issues
Summary by CodeRabbit
New Features
Bug Fixes