Skip to content

Remove TRANSITION mode, fix local kind definitions in MYJ SFC/PBL schemes#322

Merged
climbfuji merged 3 commits into
NCAR:gmtb/developfrom
climbfuji:remove_transition_mode
Sep 23, 2019
Merged

Remove TRANSITION mode, fix local kind definitions in MYJ SFC/PBL schemes#322
climbfuji merged 3 commits into
NCAR:gmtb/developfrom
climbfuji:remove_transition_mode

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Sep 20, 2019 •
edited
Loading

Changes:

  • remove all code related to the deprecated TRANSITION mode for Theia+Intel15
  • clean up the local kind definitions for new MYJ SFC/PBL schemes by importing them from machine.F (and adding them to this module if necessary)

For regression testing, see NCAR/NEMSfv3gfs#251

@climbfuji climbfuji changed the base branch from master to gmtb/develop September 21, 2019 02:05
This was referenced Sep 22, 2019
Merged
Merged
@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Sep 22, 2019

Associated PRs:

https://github.com/NCAR/FV3/pull/207
NCAR/NEMS#10
https://github.com/NCAR/NEMSfv3gfs/pull/251
NCAR/ccpp-framework#225
#322
NCAR/GFDL_atmos_cubed_sphere#2
NOAA-PSL/stochastic_physics#2

This was referenced Sep 22, 2019
Merged
Merged
@climbfuji climbfuji marked this pull request as ready for review September 22, 2019 14:05
@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Sep 22, 2019

@Qingfu-Liu for your information, this PR cleans up the use of local kind definitions for MYJ SFC/PBL.

llpcarson
llpcarson approved these changes Sep 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@llpcarson llpcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@climbfuji climbfuji merged commit d808b16 into NCAR:gmtb/develop Sep 23, 2019
@climbfuji climbfuji deleted the remove_transition_mode branch June 27, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantfirl grantfirl Awaiting requested review from grantfirl

@JulieSchramm JulieSchramm Awaiting requested review from JulieSchramm

1 more reviewer

@llpcarson llpcarson llpcarson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@climbfuji @llpcarson