Ca develop#15
Conversation
Psd/develop into master
pjpegion
left a comment
pjpegion
left a comment
There was a problem hiding this comment.
I code changes look good. Just to confirm, this will also require an update to fv3_atm? If so, I will hold off doing the merge until that gets coordinated with Jun.
That is correct. Let me know if I can help with that coordination somehow. |
|
I can take care of that. We currently have it scheduled for April 14. |
…l throughout the integration is activated
|
Associated PRs: NCAR/ccpp-physics#418 |
|
|
||
| halo=1 | ||
| k_in=1 | ||
|
|
There was a problem hiding this comment.
I suggest a code block such as:
if (nlev .EQ. 64) then
k350=29
k850=13
else (nlev. EQ. 127) then
k350=61
k850=28
else ! make a guess
k350=nint(nlev/2)
k850=nint(nlev/5)
print*,'this level selection is not supported, making an approximation for k350 and k850'
endif
There was a problem hiding this comment.
Thanks, good suggestion!
There was a problem hiding this comment.
I addressed this and results are reproduced.
There was a problem hiding this comment.
good, once you commit and push the updates, I can do the merge.
There was a problem hiding this comment.
I see in cellular_automata_sgs.F90 you have 850 hPa and 350 hPa hardcoded for the 64 level version of the model. I don't think it needs to be generic, but it needs to have support for the 127 level version. I put a suggestion in the comments section of that file.
3 participants
Cellular automata updates to be able to run global and sub-grid CA's at the same time, improvements for stochastic convection representation, some cleaning. Updates are dependent upon updates in submodules FV3 and ccpp/physics.