Unified UGWP wrapper PR around #43#44
Merged
DomHeinzeller merged 17 commits intoNov 17, 2020
Merged
Conversation
…_ccpp_gsd_short.conf and associated files for testing unified_ugwp suite. Tests to reproduce drag_suite, gsd_v0 and no_drag.
…est configurations
This was referenced Nov 16, 2020
…avoid out-of-memory errors
… and fv3_ccpp_rap
DomHeinzeller
commented
Nov 17, 2020
Author
DomHeinzeller
left a comment
DomHeinzeller
left a comment
There was a problem hiding this comment.
This PR is ready, except for the submodule pointer updates following the submodule merges, and the reversal of the .gitmodules change.
Closed
DomHeinzeller
pushed a commit
that referenced
this pull request
Dec 15, 2021
Updates CICE for the latest Consortium main. See CICE Issue #44 for a list of updates included. In particular, this PR will update the icepack submodule to include a fix which allows -init=snan,arrays to be used in debug mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes and replaces #43 and adds regression tests for the Unified Gravity Wave Drag parameterizations.
Testing
Regression testing on Cheyenne using Intel:
rt_ccpp_gsd.conf: first create new baseline, then verify against it: all tests passrt_ccpp_gsd_cheynne_intel_create.log
rt_ccpp_gsd_cheynne_intel_verify.log
rt.confagainst existing (original) baseline created withdevelop: all tests pass, except the ones expected to fail (because updates were made to gsd/develop that have not been sent back to develop yet; these tests differ in their results, but they all run to completion)rt_cheyenne_intel_against_existing_baseline.log
rt_cheyenne_intel_against_existing_baseline_fail_test.log
Regression testing on Hera using Intel:
rt_gnu.confagainst existing (original) baseline created withdevelop: all tests pass, except the ones expected to fail (because updates were made to gsd/develop that have not been sent back to develop yet; these tests differ in their results, but they all run to completion)rt_hera_intel.log
rt_hera_intel_fail_test.log
rt_ccpp_gsd.confagainst existing (original) baseline created withgsd/develop: all tests pass!rt_ccpp_gsd_hera_intel_against_gsd_original.log
Regression testing on Hera using GNU:
rt_gnu.confagainst existing (original) baseline created withdevelop: all tests pass, except the ones expected to fail (because updates were made to gsd/develop that have not been sent back to develop yet; these tests differ in their results, but they all run to completion)rt_hera_gnu.log
rt_hera_gnu_fail_test.log
Dependencies
NOAA-GSL/ccpp-physics#55
NOAA-GSL/ccpp-physics#61 (includes NOAA-GSL/ccpp-physics#55)
NOAA-GSL/fv3atm#53
NOAA-GSL/fv3atm#57 (includes NOAA-GSL/fv3atm#53)
#43
#44 (includes #43)