Unified ugwp#43
Conversation
…_ccpp_gsd_short.conf and associated files for testing unified_ugwp suite. Tests to reproduce drag_suite, gsd_v0 and no_drag.
DomHeinzeller
left a comment
DomHeinzeller
left a comment
There was a problem hiding this comment.
Something is wrong with this PR, I see updates that should be there (NEMS, WW3, stochastic_physics).
I am also a little uneasy about adding so many tests (and suite definition files in the fv3atm PR). Can we cut this down to 1 or 2 tests, with 1 or two suite definition files?
Lastly, after making all the changes in ccpp-physics and fv3atm, please make sure that the submodule pointers are pointing to the correct hashes (I haven't checked, but you'll probably need to make a few more changes to one or both of these submodules).
| fi | ||
|
|
||
| mkdir -p ${STMP}/${USER} | ||
| # mkdir -p ${STMP}/${USER} |
There was a problem hiding this comment.
Please revert the changes to rt.sh
| @@ -0,0 +1,32 @@ | |||
| ################################################################################################################################################################################# | |||
There was a problem hiding this comment.
Please remove this file tests/rt_ccpp_gsd_short.conf.
| @@ -0,0 +1,38 @@ | |||
| ################################################################################################################################################################################# | |||
There was a problem hiding this comment.
Please merge only the required tests into rt_ccpp_gsd.conf and delete tests/rt_ccpp_gsd_unified_ugwp.conf.
| export IMFDEEPCNV=3 | ||
| export LSM=3 | ||
| export LSOIL_LSM=9 | ||
| export DO_UGWP_V0=.F. |
There was a problem hiding this comment.
Lines 121-127 should also be added to tests/default_vars.sh in the appropriate place (look for the gravity wave drag options). Then they shouldn't be required here; only in the drag suite tests that change the default values.
|
Just to clarify, the changes I requested (removing some of the tests and |
Unified UGWP wrapper PR around #43
|
This PR was pulled into #44 and merged as part of it. |
3 participants
Hello,
This PR introduces the "unified_ugwp" gravity wave drag scheme, which combines three drag schemes: 1) the "cires_ugwp" scheme, 2) the GSL drag suite "drag_suite", and 3) the new "ugwp_v1" scheme developed by Valery Yudin of CIRES. The first two schemes can be regression-tested against their original respective schemes, while the "ugwp_v1" is still under development. To activate the various options, new namelist options are required, which are available from the developers.
Regards,
Mike Toy