Skip to content

Two FV3 dycore bug fixes and SGS cloud update gsd/develop 2020/06/29#32

Merged
DomHeinzeller merged 6 commits into
NOAA-GSL:gsd/developfrom
climbfuji:dycore_bugfixes_and_sgscloud_update_gsd_develop_20200629
Jun 29, 2020
Merged

Two FV3 dycore bug fixes and SGS cloud update gsd/develop 2020/06/29#32
DomHeinzeller merged 6 commits into
NOAA-GSL:gsd/developfrom
climbfuji:dycore_bugfixes_and_sgscloud_update_gsd_develop_20200629

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Jun 29, 2020 •
edited
Loading

This PR:

  • updates the submodule pointers for fv3atm, GFDL_atmos_cubed_sphere and ccpp-physics for the changes described in the PRs below
  • reactivates the regression test fv3_ccpp_gsd_sar_25km_debug (issue Reactivate regression test fv3_ccpp_gsd_sar_25km_debug #31)
  • includes a formal update from NOAA-EMC (which only contains parts of the changes described above).

Associated PRs:
NOAA-GSL/ccpp-physics#42
NOAA-GSL/GFDL_atmos_cubed_sphere#5
NOAA-GSL/fv3atm#39
#32

For regression testing information, see below.

This was referenced Jun 29, 2020
Merged
Merged
Merged
@climbfuji climbfuji changed the title PLACEHOLDER Dycore bugfixes and sgscloud update gsd develop 20200629 Two FV3 dycore bug fixes and SGS cloud update gsd/develop 2020/06/29 Jun 29, 2020
climbfuji added 4 commits June 29, 2020 09:29
@climbfuji
tests/rt_ccpp_gsd.conf: reactivate regression test fv3_ccpp_gsd_sar_2…
7a87fde 
…5km_debug
@climbfuji
Update submodule pointer for fv3atm
61eef86
@climbfuji
Bugfix for regional runs when dycore is compiled in double precision (u…
dba56e5 
…fs-community#155)

* Update .gitmodules and submodule pointer for fv3atm for code review and testing

* Regression test logs for hera.intel and hera.gnu

* Regression test logs for orion.intel

* Regression test logs for wcoss_cray and wcoss_dell_p3

* Revert change to .gitmodules and update submodule pointer for fv3atm
@climbfuji
Merge branch 'develop' of https://github.com/ufs-community/ufs-weathe…
a9cd1d6 
…r-model into dycore_bugfixes_and_sgscloud_update_gsd_develop_20200629
@climbfuji climbfuji marked this pull request as ready for review June 29, 2020 17:20
@climbfuji climbfuji requested a review from DomHeinzeller as a code owner June 29, 2020 17:20
@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Jun 29, 2020

Regression testing on hera.intel against official EMC baseline using rt.conf. The following tests fail as expected (but run to completion), all others pass.

fv3_ccpp_gsd_debug
fv3_ccpp_thompson_no_aero_debug
fv3_ccpp_thompson_debug
fv3_ccpp_thompson
fv3_ccpp_thompson_no_aero
fv3_ccpp_gsd

rt_full.log
rt_full_fail_test.log

@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Jun 29, 2020

@tanyasmirnova @joeolson42 @hannahcbarnes FYI - the SGS updates from Tanya and two bugfixes for the dycore. Will merge as soon as the rt_ccpp_gsd.conf tests finished successfully.

@climbfuji
Copy link
Copy Markdown
Author

climbfuji commented Jun 29, 2020

Regression testing on hera.intel using rt_ccpp_gsd.conf (first create, then verify). All tests pass, including the re-activated fv3_ccpp_gsd_sar_25km_debug.

rt_ccpp_gsd_create.log
rt_ccpp_gsd_verify.log

DomHeinzeller
DomHeinzeller reviewed Jun 29, 2020
View reviewed changes
Copy link
Copy Markdown

@DomHeinzeller DomHeinzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to run the tests on hera.gnu ...

@DomHeinzeller
Copy link
Copy Markdown

DomHeinzeller commented Jun 29, 2020

Regression testing on hera.gnu against official EMC baseline using rt_gnu.conf. The following tests fail as expected (but run to completion), all others pass.

fv3_ccpp_thompson
fv3_ccpp_thompson_no_aero
fv3_ccpp_gsd

rt_full_gnu.log
rt_full_gnu_fail_test.log

@DomHeinzeller DomHeinzeller merged commit 27a8a07 into NOAA-GSL:gsd/develop Jun 29, 2020
@hannahcbarnes
Copy link
Copy Markdown

hannahcbarnes commented Jun 29, 2020

I will start a retro and have the results for next week’s meeting

@hannahcbarnes
Copy link
Copy Markdown

hannahcbarnes commented Jun 29, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@DomHeinzeller DomHeinzeller DomHeinzeller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@climbfuji @DomHeinzeller @hannahcbarnes