RRFS_dev1: Add external for python_graphics.#10
Merged
christinaholtNOAA merged 2 commits intoFeb 8, 2021
Merged
Conversation
christinaholtNOAA
requested review from
chunhuazhou,
hu5970 and
jaymes-kenyon
jaymes-kenyon
approved these changes
Feb 3, 2021
chunhuazhou
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Add the NOAA-GSL adb_graphics repository as an external for running SkewT diagrams in real time.
TESTS CONDUCTED:
Ran tests under my user account to ensure that both AK and CONUS domains successfully used this external repo code.
DEPENDENCIES
The code here needs to be updated with the appropriate hash after NOAA-GSL:adb_graphics PR#66 is merged. Then it should be fine to merge. For full utility, NOAA-GSL:regional_workflow PR #40 will also need to be merged.