forked from ufs-community/regional_workflow
-
Notifications
You must be signed in to change notification settings - Fork 23
Feature/rrfs dev2 #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TrevorAlcott-NOAA
merged 23 commits into
NOAA-GSL:feature/RRFS_dev2
from
hu5970:feature/RRFS_dev2
Dec 31, 2020
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
63dbdf5
Add data assimilation cycle to workflow, including: jobs, scripts, mo…
hu5970 bddc5dd
Add data assimilation cycle information into var_defns.sh.
hu5970 9d200b6
Add scripts to generate the FV3LAM namelist for running forecast from…
hu5970 e6ae91e
Revise scripts based on Christina's comments.
hu5970 205d11a
Updated more scripts absed on Christina and Trevor's comments.
hu5970 eb9a922
Add the tasks for preprocess radar reflectivity and radar tten calcul…
hu5970 59e4186
Update code based on Christina's review.
hu5970 52da1a7
Update scripts/exregional_run_analysis.sh based on Christina's comments.
hu5970 9dd5853
Clean exregional_process_radarref.sh
hu5970 cf98f92
Added scripts for lightning process (NetCDF).
hu5970 14493fb
Add scripts to process BUFR observation files (METAR cloud, NASA LaRC…
hu5970 2ff91bd
Improve code based on Chiristina's comments.
hu5970 5152a9a
Add lightning data path.
hu5970 37ef087
Merge branch 'feature/RRFS_dev2_cld' into feature/RRFS_dev2
hu5970 fb9a46a
Add no-var cloud analysis for RRFS:
hu5970 932a082
Add more accurate descriptions to the code.
hu5970 13533e6
Check if BUFR files exist before run preprocess.
hu5970 a9476e0
Merge branch 'feature/RRFS_dev2' of https://github.com/hu5970/regiona…
hu5970 ce5b6fb
Merge branch 'feature/RRFS_dev2' into feature/RRFS_dev2
b4e2b3d
Clean the code for PR (#22) based on Christina's comments
hu5970 c2e0542
Add descriptions for namelists generated in the scripts.
hu5970 5720e07
Bug fix in generate_FV3LAM_wflow.sh for generating DA workflow.
hu5970 6c7c28a
Only give warnings if the data preprocess executable crashed.
hu5970 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| fix | ||
| ush/config.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| #!/bin/bash | ||
|
|
||
| #----------------------------------------------------------------------- | ||
| # | ||
| # This J-JOB script runs the standalone No-Var Cloud Analysis | ||
| # for the FV3-LAM model | ||
| # | ||
| #----------------------------------------------------------------------- | ||
|
|
||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Source the variable definitions file and the bash utility functions. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| . ${GLOBAL_VAR_DEFNS_FP} | ||
| . $USHDIR/source_util_funcs.sh | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Save current shell options (in a global array). Then set new options | ||
| # for this script/function. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| { save_shell_opts; set -u +x; } > /dev/null 2>&1 | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Get the full path to the file in which this script/function is located | ||
| # (scrfunc_fp), the name of that file (scrfunc_fn), and the directory in | ||
| # which the file is located (scrfunc_dir). | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| scrfunc_fp=$( readlink -f "${BASH_SOURCE[0]}" ) | ||
| scrfunc_fn=$( basename "${scrfunc_fp}" ) | ||
| scrfunc_dir=$( dirname "${scrfunc_fp}" ) | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Print message indicating entry into script. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| print_info_msg " | ||
| ======================================================================== | ||
| Entering script: \"${scrfunc_fn}\" | ||
| In directory: \"${scrfunc_dir}\" | ||
|
|
||
| This is the J-job script for the task that runs a standalone No-Var cloud | ||
| analysis with FV3 for the specified cycle. | ||
| ========================================================================" | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Create the working directory under the cycle directory. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| WORKDIR=${CYCLE_DIR}/novar_cldana | ||
| if [ -r ${WORKDIR} ]; then | ||
| rm -fr ${WORKDIR} | ||
| fi | ||
| mkdir_vrfy -p ${WORKDIR} | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Call the ex-script for this J-job and pass to it the necessary varia- | ||
| # bles. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| $SCRIPTSDIR/exregional_novarcldana.sh \ | ||
| CYCLE_DIR="${CYCLE_DIR}" WORKDIR="${WORKDIR}" || \ | ||
| print_err_msg_exit "\ | ||
| Call to ex-script corresponding to J-job \"${scrfunc_fn}\" failed." | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Print exit message. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| print_info_msg " | ||
| ======================================================================== | ||
| Exiting script: \"${scrfunc_fn}\" | ||
| In directory: \"${scrfunc_dir}\" | ||
| ========================================================================" | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Restore the shell options saved at the beginning of this script/func- | ||
| # tion. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| { restore_shell_opts; } > /dev/null 2>&1 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| #!/bin/bash | ||
|
|
||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # This J-JOB script runs the preprocess of BUFR files | ||
| # for the FV3-LAM model | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Source the variable definitions file and the bash utility functions. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| . ${GLOBAL_VAR_DEFNS_FP} | ||
| . $USHDIR/source_util_funcs.sh | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Save current shell options (in a global array). Then set new options | ||
| # for this script/function. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| { save_shell_opts; set -u +x; } > /dev/null 2>&1 | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Get the full path to the file in which this script/function is located | ||
| # (scrfunc_fp), the name of that file (scrfunc_fn), and the directory in | ||
| # which the file is located (scrfunc_dir). | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| scrfunc_fp=$( readlink -f "${BASH_SOURCE[0]}" ) | ||
| scrfunc_fn=$( basename "${scrfunc_fp}" ) | ||
| scrfunc_dir=$( dirname "${scrfunc_fp}" ) | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Print message indicating entry into script. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| print_info_msg " | ||
| ======================================================================== | ||
| Entering script: \"${scrfunc_fn}\" | ||
| In directory: \"${scrfunc_dir}\" | ||
|
|
||
| This is the J-job script for the task that runs a BUFR preprocess for | ||
| the specified cycle. | ||
| ========================================================================" | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Create the working directory under the cycle directory. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| WORKDIR=${CYCLE_DIR}/process_bufr | ||
| if [ -r ${WORKDIR} ]; then | ||
| rm -fr ${WORKDIR} | ||
| fi | ||
| mkdir_vrfy -p ${WORKDIR} | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Call the ex-script for this J-job and pass to it the necessary varia- | ||
| # bles. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| $SCRIPTSDIR/exregional_process_bufr.sh \ | ||
| CYCLE_DIR="${CYCLE_DIR}" WORKDIR="${WORKDIR}" || \ | ||
| print_err_msg_exit "\ | ||
| Call to ex-script corresponding to J-job \"${scrfunc_fn}\" failed." | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Print exit message. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| print_info_msg " | ||
| ======================================================================== | ||
| Exiting script: \"${scrfunc_fn}\" | ||
| In directory: \"${scrfunc_dir}\" | ||
| ========================================================================" | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Restore the shell options saved at the beginning of this script/func- | ||
| # tion. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| { restore_shell_opts; } > /dev/null 2>&1 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| #!/bin/bash | ||
|
|
||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # This J-JOB script runs the NetCDF ligthning observation preprocess | ||
| # for the FV3-LAM model | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Source the variable definitions file and the bash utility functions. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| . ${GLOBAL_VAR_DEFNS_FP} | ||
| . $USHDIR/source_util_funcs.sh | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Save current shell options (in a global array). Then set new options | ||
| # for this script/function. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| { save_shell_opts; set -u +x; } > /dev/null 2>&1 | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Get the full path to the file in which this script/function is located | ||
| # (scrfunc_fp), the name of that file (scrfunc_fn), and the directory in | ||
| # which the file is located (scrfunc_dir). | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| scrfunc_fp=$( readlink -f "${BASH_SOURCE[0]}" ) | ||
| scrfunc_fn=$( basename "${scrfunc_fp}" ) | ||
| scrfunc_dir=$( dirname "${scrfunc_fp}" ) | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Print message indicating entry into script. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| print_info_msg " | ||
| ======================================================================== | ||
| Entering script: \"${scrfunc_fn}\" | ||
| In directory: \"${scrfunc_dir}\" | ||
|
|
||
| This is the J-job script for the task that runs a lightning preprocess for | ||
| the specified cycle. | ||
| ========================================================================" | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Create the working directory under the cycle directory. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| WORKDIR=${CYCLE_DIR}/process_lightning | ||
| if [ -r ${WORKDIR} ]; then | ||
| rm -fr ${WORKDIR} | ||
| fi | ||
| mkdir_vrfy -p ${WORKDIR} | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Call the ex-script for this J-job and pass to it the necessary varia- | ||
| # bles. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| $SCRIPTSDIR/exregional_process_lightning.sh \ | ||
| CYCLE_DIR="${CYCLE_DIR}" WORKDIR="${WORKDIR}" || \ | ||
| print_err_msg_exit "\ | ||
| Call to ex-script corresponding to J-job \"${scrfunc_fn}\" failed." | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Print exit message. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| print_info_msg " | ||
| ======================================================================== | ||
| Exiting script: \"${scrfunc_fn}\" | ||
| In directory: \"${scrfunc_dir}\" | ||
| ========================================================================" | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| # Restore the shell options saved at the beginning of this script/func- | ||
| # tion. | ||
| # | ||
| #----------------------------------------------------------------------- | ||
| # | ||
| { restore_shell_opts; } > /dev/null 2>&1 | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is not necessary (same is true in other jobs scripts).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed all the scripts.