Skip to content

fix bugs found in pbl and ozone 3d diagnostic tendencies #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DomHeinzeller merged 7 commits into from
May 14, 2020
Merged

fix bugs found in pbl and ozone 3d diagnostic tendencies #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
464adcf
fix bugs found in pbl and ozone 3d diagnostic tendencies
SamuelTrahanNOAA May 8, 2020
80468ee
remove debugging prints
SamuelTrahanNOAA May 8, 2020
8b3abdb
implied shape arrays for five variables
SamuelTrahanNOAA May 9, 2020
2e5aa90
more block labels in CCPP
SamuelTrahanNOAA May 12, 2020
4d121db
yet more bug fixes in ccpp
SamuelTrahanNOAA May 13, 2020
77761c9
make the logging less wordy
SamuelTrahanNOAA May 13, 2020
503a8b2
point to hash 238c84cb3c789056c701b70d3373e640ed4fa599 of ccpp/physics
SamuelTrahanNOAA May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ccpp/physics
Open in desktop
Submodule physics updated from bbc6f3 to 238c84
30 changes: 20 additions & 10 deletions gfsphysics/GFS_layer/GFS_typedefs.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3311,42 +3311,52 @@ subroutine control_initialize (Model, nlunit, fn_nml, me, master, &
#ifdef CCPP

if(gwd_opt==1) then
write(0,*) 'FLAG: gwd_opt==1 so gwd not generic'
if(me==master) &
write(0,*) 'FLAG: gwd_opt==1 so gwd not generic'
Model%flag_for_gwd_generic_tend=.false.
else
elseif(me==master) then
write(0,*) 'NO FLAG: gwd is generic'
endif

if(satmedmf .and. isatmedmf==0) then
write(0,*) 'FLAG: satmedmf and isatedmf=0 so pbl not generic'
if(me==master) &
write(0,*) 'FLAG: satmedmf and isatedmf=0 so pbl not generic'
Model%flag_for_pbl_generic_tend=.false.
elseif(satmedmf .and. isatmedmf==1) then
if(me==master) &
write(0,*) 'FLAG: satmedmf and isatedmf=1 so pbl not generic'
Model%flag_for_pbl_generic_tend=.false.
else if(hybedmf) then
write(0,*) 'FLAG: hybedmf so pbl not generic'
if(me==master) &
write(0,*) 'FLAG: hybedmf so pbl not generic'
Model%flag_for_pbl_generic_tend=.false.
else if(do_mynnedmf) then
write(0,*) 'FLAG: do_mynnedmf so pbl not generic'
if(me==master) &
write(0,*) 'FLAG: do_mynnedmf so pbl not generic'
Model%flag_for_pbl_generic_tend=.false.
else
elseif(me==master) then
write(0,*) 'NO FLAG: pbl is generic'
endif

if(imfshalcnv == Model%imfshalcnv_gf) then
write(0,*) 'FLAG: imfshalcnv_gf so scnv not generic'
if(me==master) &
write(0,*) 'FLAG: imfshalcnv_gf so scnv not generic'
Model%flag_for_scnv_generic_tend=.false.
! else if(imfshalcnv == Model%imfshalcnv_samf) then
! write(0,*) 'FLAG: imfshalcnv_samf so scnv not generic'
! Model%flag_for_scnv_generic_tend=.false.
else
elseif(me==master) then
write(0,*) 'NO FLAG: scnv is generic'
endif

if(imfdeepcnv == Model%imfdeepcnv_gf) then
write(0,*) 'FLAG: imfdeepcnv_gf so dcnv not generic'
if(me==master) &
write(0,*) 'FLAG: imfdeepcnv_gf so dcnv not generic'
Model%flag_for_dcnv_generic_tend=.false.
! else if(imfdeepcnv == Model%imfdeepcnv_samf) then
! write(0,*) 'FLAG: imfdeepcnv_samf so dcnv not generic'
! Model%flag_for_dcnv_generic_tend=.false.
else
elseif(me==master) then
write(0,*) 'NO FLAG: dcnv is generic'
endif
#endif
Expand Down