fix bugs found in pbl and ozone 3d diagnostic tendencies#26
Merged
DomHeinzeller merged 7 commits intoMay 14, 2020
Merged
Conversation
This was referenced May 8, 2020
|
I see a ton of messages like in the output. We should only print those for the master task in |
|
fv3atm was just updated (PR #27; submodule pointer update only). Please update your branch. Thanks! |
Collaborator
Author
|
The aforementioned problems are resolved in my latest commit. |
|
I merged NOAA-GSL/ccpp-physics#27. Can you please update the submodule pointer for ccpp-physics in your fv3atm branch to point to: Then, fix the merge conflict for ufs-weather-model and update the submodule pointer for fv3atm. Once this is done, I can approve and merge fv3atm. Thanks! |
DomHeinzeller
approved these changes
May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PBL tendencies were missing in two schemes; now fixed.
ccpp PR: NOAA-GSL/ccpp-physics#27
ufs-weather-model PR: NOAA-GSL/ufs-weather-model#20