Bug fixes to 3D diagnostic tendencies (based on #15)#19
Merged
DomHeinzeller merged 33 commits intoApr 22, 2020
Conversation
…e should calculate the 3D diagnostic tendencies.
… and physics/moninedmf.f
…s, implement model/ccpp/total tendencies.
…dded model and cppp tendency variables
…model tendencies add up to total change in 3 hours for the gfs v16 beta suite
… tendencies for gvsv15p2
…g tendency in GFS_diagnostics.F90
… of individual physics tendencies, combined physics tendencies and non-physics tendencies
This was referenced Apr 17, 2020
…cies at the end of stochstastic_physics
DomHeinzeller
added
do not merge
DomHeinzeller
removed
do not merge
DomHeinzeller
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the original PR #15. It reverts some of the modifications made, notably the calculation of tendencies from non-physics processes in CCPP. Instead, these are calculated in the appropriate place in
atmos_model.F90.Associated PRs:
NOAA-GSL/ccpp-physics#21
#19
NOAA-GSL/ufs-weather-model#16
For regression testing information, see NOAA-GSL/ufs-weather-model#16.