Skip to content

Bug fixes to 3D diagnostic tendencies (based on #18)#21

Merged
DomHeinzeller merged 17 commits into
NOAA-GSL:gsd/developfrom
climbfuji:tendencies_sam_with_dom_mods
Apr 22, 2020
Merged

Bug fixes to 3D diagnostic tendencies (based on #18)#21
DomHeinzeller merged 17 commits into
NOAA-GSL:gsd/developfrom
climbfuji:tendencies_sam_with_dom_mods

Conversation

@climbfuji
Copy link
Copy Markdown

@climbfuji climbfuji commented Apr 16, 2020

This PR builds on the original PR #18. It reverts some of the modifications made, notably the calculation of tendencies from non-physics processes in CCPP.

Associated PRs:

#21
NOAA-GSL/fv3atm#19
NOAA-GSL/ufs-weather-model#16

For regression testing information, see NOAA-GSL/ufs-weather-model#16.

@DomHeinzeller DomHeinzeller added do not merge Something is wrong, do not merge work in progress Still being worked on labels Apr 20, 2020
@DomHeinzeller DomHeinzeller marked this pull request as ready for review April 20, 2020 22:00
@DomHeinzeller DomHeinzeller self-requested a review as a code owner April 20, 2020 22:00
@DomHeinzeller DomHeinzeller removed do not merge Something is wrong, do not merge work in progress Still being worked on labels Apr 21, 2020
@DomHeinzeller DomHeinzeller merged commit 314c5f5 into NOAA-GSL:gsd/develop Apr 22, 2020
mdtoyNOAA pushed a commit to mdtoyNOAA/ccpp-physics that referenced this pull request Mar 29, 2022
modify the eddy diffusivity for heat at the top of the canopy
@climbfuji climbfuji deleted the tendencies_sam_with_dom_mods branch June 27, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants