Wrapper PR for #97 (Update of GF aerosol treatment and tunings) and #98 (Updates to MYNN-EDMF)#99
Conversation
DomHeinzeller
requested review from
SamuelTrahanNOAA,
hannahcbarnes,
joeolson42 and
tanyasmirnova
hannahcbarnes
left a comment
hannahcbarnes
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for your help @DomHeinzeller. Glad to see that adding the 1e-8 factor in cu_gf_deep for qc and qch resolved the issue.
hannahcbarnes
left a comment
hannahcbarnes
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for your help @DomHeinzeller with the crashes.
SamuelTrahanNOAA
left a comment
SamuelTrahanNOAA
left a comment
There was a problem hiding this comment.
Some issues in the code might get flagged by upstream reviewers, but they don't bother me much. I approve.
| flag_for_scnv_generic_tend,flag_for_dcnv_generic_tend, & | ||
| dtend,dtidx,ntqv,ntiw,ntcw,index_of_temperature,index_of_x_wind, & | ||
| index_of_y_wind,index_of_process_scnv,index_of_process_dcnv, & | ||
| index_of_y_wind,index_of_process_scnv,index_of_process_dcnv, & |
There was a problem hiding this comment.
You have a trailing space on this line. That isn't a big deal, but it may annoy other reviewers when this goes upstream.
| do k=kts,ktf | ||
| do i=its,itf | ||
| tem = (cuten(i)*outq(i,k) + cutenm(i)*outqm(i,k))* dt | ||
| tem = (cuten(i)*outq(i,k) + cutenm(i)*outqm(i,k))* dt |
There was a problem hiding this comment.
There are two trailing space on this line, which may bother upstream reviewers.
| b(1)=1.+dtz(k)*dfh(k+1) - 0.5*dtz(k)*s_aw(k+1) | ||
| c(1)=-dtz(k)*dfh(k+1) - 0.5*dtz(k)*s_aw(k+1) | ||
| d(1)=chem1(k,ic) + dtz(k) * -vd1(ic)*chem1(1,ic) - dtz(k)*s_awchem(k+1,ic) | ||
| !a(1)=0. |
There was a problem hiding this comment.
Does this commented-out code need to be in the repository?
There was a problem hiding this comment.
Certainly not. I'll remove it.
| @@ -6226,7 +6591,7 @@ SUBROUTINE DMP_mf( & | |||
| edmf_ent(K)=edmf_ent(K)+UPA(K,i)*ENT(K,i) | |||
| edmf_qc(K) =edmf_qc(K) +UPA(K,i)*UPQC(K,i) | |||
| #if (WRF_CHEM == 1) | |||
There was a problem hiding this comment.
Is this dead code? Do we ever define WRF_CHEM=1 in FV3?
There was a problem hiding this comment.
It isn't used by me but maybe Ravan and Jordan use it. All WRF_CHEM if-defs will be removed soon as part of our ongoing work to "universalize" the MYNN to all dycores. This will be completed along with the merge with Laura Fowler's version of MYNN-EDMF. At that point, this WRF-CHEM code will be officially absorbed into the MYNN and probably regulated/protected by a new namelist option.
|
All good points, @SamuelTrahanNOAA . Lots of cleanup work that needs to be done (at some point ...) |
joeolson42
left a comment
joeolson42
left a comment
There was a problem hiding this comment.
I am never satisfied but I approve it anyway.
DomHeinzeller
left a comment
DomHeinzeller
left a comment
There was a problem hiding this comment.
GSD warmstart runs fail with both Intel and GNU - this needs to be fixed before the code can be merged.
Minor code clean up
…hysics into gsl_develop_hannah_and_joe_changes_combined_20210712
…ysics/cu_gf_driver_pre.meta
… physics/cu_gf_driver.F90 to achieve b4b identical results in restart runs
DomHeinzeller
left a comment
DomHeinzeller
left a comment
There was a problem hiding this comment.
Regression tests pass as required after several bug fixes.
climbfuji
deleted the
gsl_develop_hannah_and_joe_changes_combined_20210712
branch
Reorganization of physics repository
5 participants
This PR combines the changes in #97 and #98 and adds one additional bugfix in
cu_gf_deep.F90to preventqc(i,k)being zero.Associated PRs:
#99
NOAA-GSL/fv3atm#101
NOAA-GSL/ufs-weather-model#95
For regression testing, see NOAA-GSL/ufs-weather-model#95