gwdc.f, gwdps.f, gscond.f: merge updates from gfsphysics#99
Merged
Conversation
climbfuji
reviewed
Jun 20, 2018
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Changes to physics/gwdps.f look great. physics/gscond.f and physics/gwdc.f: a lot of the changes (in particular, all changes for physics/gscond.f) are just adding trailing whitespaces that we had removed earlier on in CCPP. Please revert those changes.
Contributor
Author
|
This PR is only for gwdc.f. I am still working on gwdps.f and gscond.f in this branch though |
climbfuji
reviewed
Jun 25, 2018
| !----- ALSO INCLUDED IS DECREASE IN DE-ACC AT TOP BY 1/2 | ||
| !----- THE NMC GWD INCORPORATING BOTH GLAS(P&S) AND GFDL(MIGWD) | ||
| !----- MOUNTAIN INDUCED GRAVITY WAVE DRAG | ||
| !----- MOUNTAIN INDUCED GRAVITY WAVE DRAG |
Collaborator
There was a problem hiding this comment.
@mzhangw can you please remove the trailing whitespaces that your PR reintroduces? In particular in this file gwdps.f. Thank you!
climbfuji
reviewed
Jun 25, 2018
| &, cond, rdt, us, cclimit, climit | ||
| &, tmt0, tmt15, qik, cwmik | ||
| &, ai, qw, u00ik, tik, pres, pp0, fi | ||
| &, ai, qw, u00ik, tik, pres, pp0, fi |
Collaborator
There was a problem hiding this comment.
same for gscond.f - please do not reintroduce trailing whitespaces.
climbfuji
reviewed
Jun 25, 2018
| ! ??? ?? 2015 J. Alpert - reducing the magnitude of tauctmax to fix blow up in L64 GFS | ||
| ! S. Kar & M. Young | ||
| ! aug 15 2016 - S. Moorthi - Fix for exessive dissipation which led to blow up in | ||
| ! aug 15 2016 - S. Moorthi - Fix for exessive dissipation which led to blow up in |
Collaborator
There was a problem hiding this comment.
and same here for gwdc.f
Contributor
Author
|
Sure. I am still working on gwdps.f, and will submit a PR for gwdps soon,
then for gscond
BTW, some white spaces are merged from operational version. I will omit
them.
…On Mon, Jun 25, 2018 at 11:14 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In physics/gwdc.f
<#99 (comment)>:
> @@ -196,7 +196,7 @@ subroutine gwdc_run (im,ix,km,lat,u1,v1,t1,q1,deltim, &
! 2013 S. Moorthi - Updated and optimized code for T1534 GFS implementation
! ??? ?? 2015 J. Alpert - reducing the magnitude of tauctmax to fix blow up in L64 GFS
! S. Kar & M. Young
-! aug 15 2016 - S. Moorthi - Fix for exessive dissipation which led to blow up in
+! aug 15 2016 - S. Moorthi - Fix for exessive dissipation which led to blow up in
and same here for gwdc.f
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#99 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ab87atBCYUvKL2inwygA2E2-CdVpwFzSks5uARpfgaJpZM4Uvw04>
.
|
mzhangw
changed the title
climbfuji
approved these changes
Jul 2, 2018
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Approved, great work!
uturuncoglu
pushed a commit
to uturuncoglu/ccpp-physics
that referenced
this pull request
Jan 8, 2024
Reorganization of physics repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update ccpp/physics/gwdc.f with NEMSfv3gfs. Got B4B results on theia with CCPP