Skip to content

gsd/develop: handle blocked data structures in init and finalize routines, revert workaround in mp_thompson_init, metadata cleanup#29

Merged
DomHeinzeller merged 10 commits into
NOAA-GSL:gsd/developfrom
climbfuji:gsd_develop_blocked_data_structures
Jun 1, 2020
Merged

gsd/develop: handle blocked data structures in init and finalize routines, revert workaround in mp_thompson_init, metadata cleanup#29
DomHeinzeller merged 10 commits into
NOAA-GSL:gsd/developfrom
climbfuji:gsd_develop_blocked_data_structures

Conversation

@climbfuji

@climbfuji climbfuji commented May 27, 2020

Copy link
Copy Markdown

Changes in this PR:

  • bugfixes for RRTMGP code: add missing mandatory CCPP arguments errmsg and errflg to several CCPP entry points
  • remove physics/GFS_suite_init_finalize_test.*
  • clean up inconsistent use of horizontal_dimension versus horizontal_loop_extent in a large number of files
  • physics/GFS_debug.F90: bugfix for conditionally allocated variables
  • physics/module_bl_mynn.F90: fix compiler warning
  • physics/mp_thompson.{F90,meta}: revert workaround in mp_thompson_init; remove physics/mp_thompson.meta.backup.before.workaround

Associated PRs:

NOAA-GSL/ccpp-framework#4
#29
NOAA-GSL/fv3atm#30
NOAA-GSL/ufs-weather-model#23

For regression testing information, see NOAA-GSL/ufs-weather-model#23.

@climbfuji climbfuji changed the title gsd/develop: handle blocked data structures in init and finalize routines gsd/develop: handle blocked data structures in init and finalize routines, revert workaround in mp_thompson_init May 27, 2020
@climbfuji climbfuji changed the title gsd/develop: handle blocked data structures in init and finalize routines, revert workaround in mp_thompson_init gsd/develop: handle blocked data structures in init and finalize routines, revert workaround in mp_thompson_init, metadata cleanup May 27, 2020
@climbfuji climbfuji marked this pull request as ready for review May 28, 2020 17:25
@climbfuji climbfuji requested a review from DomHeinzeller as a code owner May 28, 2020 17:25
@DomHeinzeller DomHeinzeller merged commit 64e8ff6 into NOAA-GSL:gsd/develop Jun 1, 2020
@climbfuji climbfuji deleted the gsd_develop_blocked_data_structures branch June 27, 2022 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants