Skip to content

gsd/develop: handle blocked data structures in init and finalize routines, remove pset logic#4

Merged
DomHeinzeller merged 11 commits into
NOAA-GSL:gsd/developfrom
climbfuji:gsd_develop_blocked_data_structures
Jun 1, 2020
Merged

gsd/develop: handle blocked data structures in init and finalize routines, remove pset logic#4
DomHeinzeller merged 11 commits into
NOAA-GSL:gsd/developfrom
climbfuji:gsd_develop_blocked_data_structures

Conversation

@climbfuji

@climbfuji climbfuji commented May 27, 2020

Copy link
Copy Markdown

Changes in this PR:

  • remove pset logic from scripts/ccpp_prebuild.py and scripts/mkdoc.py
  • bugfixes for generating list of requested versus provided variables (CCPP_VARIABLES_*.pdf)
  • improved error detection for optional arguments
  • add additional unit conversions K<->C and g kg-1 <-> kg kg-1
  • handling of blocked data structures in _init and _finalize routines, requires using the dimension (existing) and active (new; name subject to change) metadata attributes
  • remove support for old metadata standard
  • add legacy extension to handle inconsistent use of horizontal_dimension versus horizontal_loop_extent (otherwise a huge amount of metadata-only changes would have to be made; this should be done in a separate follow-up PR)
  • support for handling conditionally allocated/used variables when converting blocked data structures or units

Associated PRs:

#4
NOAA-GSL/ccpp-physics#29
NOAA-GSL/fv3atm#30
NOAA-GSL/ufs-weather-model#23

For regression testing information, see NOAA-GSL/ufs-weather-model#23.

climbfuji added 8 commits May 18, 2020 09:13
…ersions K<->C and g kg-1 <-> kg kg-1

scripts/common.py: additional definitions required for handling blocked data structures
…iminary name) from new metadata; remove support for old metadata standard; add legacy extension code to handle inconsistent use of horizontal_dimension versus horizontal_loop_extent
…n _init and _finalize routines, support for handling conditionally allocated/used variables when converting blocked data structures or units
@climbfuji climbfuji marked this pull request as ready for review May 28, 2020 20:16
@climbfuji climbfuji requested a review from DomHeinzeller as a code owner May 28, 2020 20:16
@DomHeinzeller DomHeinzeller merged commit e883bb0 into NOAA-GSL:gsd/develop Jun 1, 2020
@climbfuji climbfuji deleted the gsd_develop_blocked_data_structures branch June 27, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants